Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.0 #4078 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 342 342
Lines 15549 15549
Branches 1695 1695
=======================================
Hits 15276 15276
Misses 134 134
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1836a65 to
838c9f5
Compare
|
|
||
|
|
||
| class CommaSplittedPath(click.Path): | ||
| class CommaSplitPath(click.Path): |
There was a problem hiding this comment.
Can't rename this in v2 since it's a public class. We could add an alias and deprecate it, or do this move in v3
There was a problem hiding this comment.
Aiming at v3 currently but should I add a deprecation too?
There was a problem hiding this comment.
Would it be better to aim at main instead?
| @@ -0,0 +1,12 @@ | |||
| [default] | |||
| extend-ignore-re = ["(?Rm)^.*(#|//)\\s*codespell:ignore\\s*$"] | |||
There was a problem hiding this comment.
Note this is arbitrary the way it's defined. Matching previous codespell tool
|
|
||
| [default.extend-words] | ||
| selectin = 'selectin' | ||
| odf = 'odf' |
There was a problem hiding this comment.
Required for https://github.com/adhtruong/litestar/blob/refactor-use-typos/tests/examples/test_request_data.py#L77. Feels like an identifier so adding here rather than inlining
838c9f5 to
07bf2cb
Compare
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4078 |
|
Closing in favour of targeting main here #4080 |
Description
Closes