fix: Fix #4035 - incorrect deprecation warning issued when subclassing middlewares#4036
Merged
provinzkraut merged 1 commit intomainfrom Feb 27, 2025
Merged
Conversation
30ca1db to
b95fda3
Compare
b95fda3 to
32bf3d3
Compare
cofin
approved these changes
Feb 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4036 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 348 348
Lines 15823 15823
Branches 1748 1748
=======================================
Hits 15561 15561
Misses 125 125
Partials 137 137 ☔ View full report in Codecov by Sentry. |
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4036 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug introduced in #3996 that would incorrectly issue a deprecation warning if a user subclassed a Litestar built-in middleware which itself subclasses
AbstractMiddleware.Fix consists of checking the mro to ensure we're only warning if the subclass has
AbstractMiddlewareas a direct ancestor within the user code.Fix #4035