fix: Warn about using streaming responses with a body#4033
Merged
provinzkraut merged 1 commit intomainfrom Feb 27, 2025
Merged
Conversation
0148dda to
12acc4d
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4033 +/- ##
==========================================
- Coverage 98.35% 98.34% -0.02%
==========================================
Files 348 348
Lines 15821 15823 +2
Branches 1747 1748 +1
==========================================
Hits 15561 15561
- Misses 124 125 +1
- Partials 136 137 +1 ☔ View full report in Codecov by Sentry. |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4033 |
cofin
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Litestar allows passing in a
bodyparameter for a streaming response, but this parameter is ignored.I'm adding a deprecation warning for this parameter, so we can remove it in v3.