fix: check for default headers before appending to cors header failures#4015
Merged
provinzkraut merged 3 commits intolitestar-org:mainfrom Feb 27, 2025
Merged
fix: check for default headers before appending to cors header failures#4015provinzkraut merged 3 commits intolitestar-org:mainfrom
provinzkraut merged 3 commits intolitestar-org:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4015 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 348 348
Lines 15823 15824 +1
Branches 1748 1748
=======================================
+ Hits 15561 15562 +1
Misses 125 125
Partials 137 137 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
i.e. dio sent this |
Member
provinzkraut
left a comment
There was a problem hiding this comment.
Looks good, except for the unrelated change. Can you remove that?
provinzkraut
approved these changes
Feb 27, 2025
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4015 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes