feat: Make better error message for invalid --app string#3977
Merged
provinzkraut merged 5 commits intolitestar-org:mainfrom Feb 2, 2025
RenameMe1:main
Merged
feat: Make better error message for invalid --app string#3977provinzkraut merged 5 commits intolitestar-org:mainfrom RenameMe1:main
provinzkraut merged 5 commits intolitestar-org:mainfrom
RenameMe1:main
Conversation
Contributor
|
related: #3895 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3977 +/- ##
=======================================
Coverage 98.34% 98.35%
=======================================
Files 347 347
Lines 15756 15764 +8
Branches 1741 1741
=======================================
+ Hits 15496 15504 +8
Misses 124 124
Partials 136 136 ☔ View full report in Codecov by Sentry. |
RenameMe1
commented
Jan 28, 2025
sobolevn
reviewed
Jan 29, 2025
Member
|
@RenameMe1 Can you address the missing coverage? |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3977 |
provinzkraut
approved these changes
Feb 2, 2025
Contributor
Author
|
@all-contributors |
Contributor
|
I've put up a pull request to add @RenameMe1! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
• I added new func that output readable errors when --app arg take invalid argument and stop process
I will be glad to receive feedback 😊.
Closes
Closes #3893