Skip to content

Fix to avoid fatal error on array merge#474

Merged
hi-hai merged 1 commit intolitespeedtech:devfrom
brunocantuaria:patch-1
Jul 27, 2022
Merged

Fix to avoid fatal error on array merge#474
hi-hai merged 1 commit intolitespeedtech:devfrom
brunocantuaria:patch-1

Conversation

@brunocantuaria
Copy link
Copy Markdown
Contributor

No description provided.

@brunocantuaria
Copy link
Copy Markdown
Contributor Author

@Snowbaha
Copy link
Copy Markdown

Snowbaha commented Jul 27, 2022

another fix is to check the array on line 583 :

$data_array = is_array($data) ? $data : [];
$existing_summary_array= is_array($existing_summary) ? $existing_summary : [];
$new_summary = array_merge( $existing_summary_array, $data_array );

and another fix on line 579:
$existing_summary = static::cls()->_summary ?? null;

@hi-hai
Copy link
Copy Markdown
Collaborator

hi-hai commented Jul 27, 2022

Thanks for your PR. Please commit to dev branch

We were thinking about that fix, but got the conclusion that it is not needed.

image

However, it is good to have tho. Will include it.

@hi-hai hi-hai changed the base branch from master to dev July 27, 2022 13:20
@hi-hai hi-hai merged commit 305bf23 into litespeedtech:dev Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants