Skip to content

Add cmake export#59

Merged
litespeedtech merged 1 commit intolitespeedtech:masterfrom
talregev:TalR/export_cmake
Sep 2, 2024
Merged

Add cmake export#59
litespeedtech merged 1 commit intolitespeedtech:masterfrom
talregev:TalR/export_cmake

Conversation

@talregev
Copy link
Copy Markdown
Contributor

Add cmake export

@talregev talregev force-pushed the TalR/export_cmake branch 2 times, most recently from f8e2fb9 to 883ac01 Compare August 28, 2024 17:09
@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Aug 31, 2024

I saw you merge my other PR, but you didn't comment on this PR.
I will explain more about this one.
I did this PR, because on vcpkg, we export unofficial cmake export of ls-qpack. vcpkg and other libraries use ls-qpack cmake export to find ls-qpack library and include folder and it dependencies with find_packge in cmake.
So I wanted to add an official cmake export.
You can see this PR that already merge:
microsoft/vcpkg#40652

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Sep 1, 2024

@litespeedtech
Thank you for merge my 2 other PRs.

Can you make a comment on this PR?

@litespeedtech litespeedtech merged commit 45cc951 into litespeedtech:master Sep 2, 2024
@talregev talregev deleted the TalR/export_cmake branch September 2, 2024 14:11
@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Sep 2, 2024

Thank you for your merge.
Can you release a new version of ls-qpack?
Then I can change to official cmake export on vcpkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants