Skip to content
This repository was archived by the owner on Jan 2, 2023. It is now read-only.

71 move litentry-primitives to litentry/primitives#75

Merged
Kailai-Wang merged 13 commits intodevfrom
71-move-litentry-primitives-to-litentryprimitives
Sep 21, 2022
Merged

71 move litentry-primitives to litentry/primitives#75
Kailai-Wang merged 13 commits intodevfrom
71-move-litentry-primitives-to-litentryprimitives

Conversation

@ziming-zung
Copy link
Copy Markdown
Contributor

resolves #71
resolves #66

@ziming-zung ziming-zung linked an issue Sep 21, 2022 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maybe we could add the 'cargo clippy' to the default commit checking. It's a bitte annoying to fail CI because of clippy.

Copy link
Copy Markdown
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooks good now, thanks!

@Kailai-Wang Kailai-Wang merged commit 8f5f501 into dev Sep 21, 2022
@Kailai-Wang Kailai-Wang deleted the 71-move-litentry-primitives-to-litentryprimitives branch September 21, 2022 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move litentry-primitives to litentry/primitives Transition to struct-like Identity

3 participants