This repository was archived by the owner on Jan 2, 2023. It is now read-only.
Merged
Conversation
added 17 commits
October 14, 2022 15:12
# Conflicts: # enclave-runtime/Cargo.lock
Kailai-Wang
approved these changes
Oct 26, 2022
Collaborator
Kailai-Wang
left a comment
There was a problem hiding this comment.
Looks good thanks.
Two extra comments:
-
for the nonce fix, is it possible to have a (unit-)test for it? I'm thinking maybe we should raise an upstream PR too. For that it's best to have tests for repro-case.
-
For ts-tests let's add a README at least to briefly describe how to test it manually.
If you want you can address them in another PR. This PR is ready to be merged :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #108
resolves #118
resolves #121
Because the challenge_code is different every time, the integration test has not been added to CI yet.