Conversation
… 1205-remove-mockserver # Conflicts: # tee-worker/Cargo.lock # tee-worker/litentry/core/mock-server/Cargo.toml # tee-worker/litentry/core/mock-server/src/lib.rs # tee-worker/litentry/core/mock-server/src/twitter_official.rs # tee-worker/service/Cargo.toml # tee-worker/service/src/main.rs
# Conflicts: # tee-worker/litentry/core/data-providers/src/discord_litentry.rs # tee-worker/litentry/core/data-providers/src/discord_official.rs # tee-worker/litentry/core/data-providers/src/graphql.rs # tee-worker/litentry/core/data-providers/src/twitter_litentry.rs # tee-worker/litentry/core/data-providers/src/twitter_official.rs # tee-worker/litentry/core/mock-server/Cargo.toml # tee-worker/litentry/core/mock-server/src/graphql.rs # tee-worker/litentry/core/mock-server/src/lib.rs # tee-worker/litentry/core/mock-server/src/twitter_official.rs # tee-worker/service/Cargo.toml # tee-worker/service/src/main.rs
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #1247 +/- ##
=======================================
Coverage 19.65% 19.66%
=======================================
Files 261 261
Lines 11883 11881 -2
=======================================
Hits 2336 2336
+ Misses 9547 9545 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
BillyWooo
left a comment
There was a problem hiding this comment.
Overall it looks good to me.
Please also update tee-worker/scripts/launch.sh accordingly.
Kailai-Wang
left a comment
There was a problem hiding this comment.
Looks good, thanks.
Actually I'm thinking this way of retrieving challenge code (mock-server thread -> ffi -> enclave -> global cache) might be an overkill, as we do have the trusted/untrusted RPC query to retrieve the state of the sidechain storage. Maybe it's enough to simply add another RPC method.
I also want to implement in this way at first. There is a point to consider here, whether there are any potential risks in exposing storage value via RPC. see: #1010 |
|
They will be used for development only, no RPC will be exposed in production - even if there're such requirements, we have to consider it prudently |
|
Another question: Can we enable the mock server by default in |
Done |
Let's implement it in the next PR |
|
All good, thanks. Feel free to merge it once CI passes. |
This PR
resolves #1205
resolves #1073