Merged
Conversation
added 9 commits
January 21, 2023 01:02
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #1236 +/- ##
==========================================
- Coverage 19.76% 19.65% -0.11%
==========================================
Files 258 260 +2
Lines 11816 11882 +66
==========================================
Hits 2336 2336
- Misses 9480 9546 +66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DogLi
reviewed
Jan 30, 2023
Contributor
|
LGFM |
Kailai-Wang
reviewed
Jan 30, 2023
Kailai-Wang
approved these changes
Jan 30, 2023
Collaborator
Kailai-Wang
left a comment
There was a problem hiding this comment.
Looks good, thanks!
BillyWooo
reviewed
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #1207