Skip to content

Add a small note about type checking context#1134

Merged
rictic merged 4 commits intomainfrom
note-context-type-checking
May 31, 2023
Merged

Add a small note about type checking context#1134
rictic merged 4 commits intomainfrom
note-context-type-checking

Conversation

@rictic
Copy link
Copy Markdown
Contributor

@rictic rictic commented May 31, 2023

I didn't want to go into the full details because it felt like it would disrupt the flow of this page, and the main information that people need to know is that we're not type checking private or protected fields.

I didn't want to go into the full details because it felt like it would disrupt the flow of this page, and the main information that people need to know is that we're not type checking private or protected fields.
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 31, 2023

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1134-31657ae---lit-dev-5ftespv5na-uc.a.run.app/
https://pr1134-4b7e7bd---lit-dev-5ftespv5na-uc.a.run.app/
https://pr1134-b6aa371---lit-dev-5ftespv5na-uc.a.run.app/
https://pr1134-300f75e---lit-dev-5ftespv5na-uc.a.run.app/

Copy link
Copy Markdown
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - I'm a little torn about whether it's worth adding the comment as I'm not sure how many will see it and who is the audience.

Maybe the comment should be rephrased as a TODO linking to the issue so we can update docs when the situation changes?

@rictic
Copy link
Copy Markdown
Contributor Author

rictic commented May 31, 2023

Yeah, the comment is there for maintainers of the site, not for visitors. Clarified into a TODO

Thanks for the review!

@rictic rictic merged commit 5a122b2 into main May 31, 2023
@rictic rictic deleted the note-context-type-checking branch May 31, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants