[all] Update Rollup packages by justinfagnani · Pull Request #4681 · lit/lit

justinfagnani · 2024-06-23T22:12:52Z

Updating Rollup and related packages, initially to try to get rid of this error message we have on npm install:

npm install error

➜  lit git:(main) ✗ npm ci
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @rollup/pluginutils@3.1.0
npm warn Found: rollup@4.18.0
npm warn node_modules/rollup
npm warn   dev rollup@"^4.18.0" from the root project
npm warn   11 more (@rollup/plugin-commonjs, @rollup/plugin-inject, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer rollup@"^1.20.0||^2.0.0" from @rollup/pluginutils@3.1.0
npm warn node_modules/rollup-plugin-sourcemaps/node_modules/@rollup/pluginutils
npm warn   @rollup/pluginutils@"^3.0.9" from rollup-plugin-sourcemaps@0.6.3
npm warn   node_modules/rollup-plugin-sourcemaps
npm warn
npm warn Conflicting peer dependency: rollup@2.79.1
npm warn node_modules/rollup
npm warn   peer rollup@"^1.20.0||^2.0.0" from @rollup/pluginutils@3.1.0
npm warn   node_modules/rollup-plugin-sourcemaps/node_modules/@rollup/pluginutils
npm warn     @rollup/pluginutils@"^3.0.9" from rollup-plugin-sourcemaps@0.6.3
npm warn     node_modules/rollup-plugin-sourcemaps
npm warn deprecated glob@8.1.0: Glob versions prior to v9 are no longer supported

It turns out that rollup-plugin-sourcemaps is seemingly unmaintained right now and has this issue open for Rollup 3 and 4 compatibility. A user reported that an npm override for @rollup/pluginutils fixed the error though, so I applied that as well.

changeset-bot · 2024-06-23T22:12:56Z

🦋 Changeset detected

Latest commit: 3a7d6cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@lit/localize	Patch
@lit/lit-starter-js	Patch
@lit/lit-starter-ts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-06-23T22:13:05Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -11% - -0% (-1.28ms - +0.02ms)
^{this-change vs tip-of-tree}

render

this-change: 45.45ms - 46.92ms
this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +1% (-0.82ms - +0.17ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-0.81ms - +0.28ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.59ms - +0.53ms)
^{this-change vs tip-of-tree}

update

this-change: 488.49ms - 496.57ms
this-change, tip-of-tree, previous-release: faster ✔ 3% - 14% (1.19ms - 5.44ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-1.58ms - +1.73ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-9.31ms - +6.28ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 491.44ms - 498.02ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-5.93ms - +10.04ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 126.0.6478.61
Sample size: 50
Built by: Benchmarks #6292
Commit: 3a7d6cd

render

Version	Avg time	vs
	45.45ms - 46.92ms	-

update

Version	Avg time	vs
	488.49ms - 496.57ms	-

update-reflect

Version	Avg time	vs
	491.44ms - 498.02ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 126.0.6478.61
Sample size: 30
Built by: Benchmarks #6292
Commit: 3a7d6cd

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	17.90ms - 18.62ms	-	unsure 🔍 -4% - +1% -0.82ms - +0.17ms	unsure 🔍 -5% - +1% -1.01ms - +0.14ms
tip-of-tree tip-of-tree	18.25ms - 18.92ms	unsure 🔍 -1% - +4% -0.17ms - +0.82ms	-	unsure 🔍 -4% - +2% -0.67ms - +0.44ms
previous-release previous-release	18.25ms - 19.14ms	unsure 🔍 -1% - +6% -0.14ms - +1.01ms	unsure 🔍 -2% - +4% -0.44ms - +0.67ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.69ms - 37.46ms	-	faster ✔ 3% - 14% 1.19ms - 5.44ms	unsure 🔍 -11% - +1% -4.19ms - +0.28ms
tip-of-tree tip-of-tree	37.78ms - 41.00ms	slower ❌ 3% - 15% 1.19ms - 5.44ms	-	unsure 🔍 -3% - +10% -1.03ms - +3.75ms
previous-release previous-release	36.27ms - 39.79ms	unsure 🔍 -1% - +12% -0.28ms - +4.19ms	unsure 🔍 -9% - +3% -3.75ms - +1.03ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.75ms - 11.42ms	-	unsure 🔍 -11% - -0% -1.28ms - +0.02ms	unsure 🔍 -5% - +3% -0.62ms - +0.37ms
tip-of-tree tip-of-tree	11.16ms - 12.27ms	unsure 🔍 -0% - +12% -0.02ms - +1.28ms	-	unsure 🔍 -1% - +10% -0.16ms - +1.17ms
previous-release previous-release	10.85ms - 11.57ms	unsure 🔍 -3% - +6% -0.37ms - +0.62ms	unsure 🔍 -10% - +1% -1.17ms - +0.16ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 126.0.6478.61
Sample size: 50
Built by: Benchmarks #6292
Commit: 3a7d6cd

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.36ms - 34.06ms	-	unsure 🔍 -2% - +1% -0.81ms - +0.28ms	unsure 🔍 -2% - +1% -0.64ms - +0.24ms
tip-of-tree tip-of-tree	33.56ms - 34.39ms	unsure 🔍 -1% - +2% -0.28ms - +0.81ms	-	unsure 🔍 -1% - +2% -0.42ms - +0.56ms
previous-release previous-release	33.64ms - 34.17ms	unsure 🔍 -1% - +2% -0.24ms - +0.64ms	unsure 🔍 -2% - +1% -0.56ms - +0.42ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	69.34ms - 71.82ms	-	unsure 🔍 -2% - +2% -1.58ms - +1.73ms	unsure 🔍 -2% - +2% -1.60ms - +1.57ms
tip-of-tree tip-of-tree	69.42ms - 71.60ms	unsure 🔍 -2% - +2% -1.73ms - +1.58ms	-	unsure 🔍 -2% - +2% -1.56ms - +1.38ms
previous-release previous-release	69.61ms - 71.58ms	unsure 🔍 -2% - +2% -1.57ms - +1.60ms	unsure 🔍 -2% - +2% -1.38ms - +1.56ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 126.0.6478.61
Sample size: 50
Built by: Benchmarks #6292
Commit: 3a7d6cd

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	30.40ms - 31.19ms	-	unsure 🔍 -2% - +2% -0.59ms - +0.53ms	unsure 🔍 -2% - +2% -0.53ms - +0.64ms
tip-of-tree tip-of-tree	30.42ms - 31.22ms	unsure 🔍 -2% - +2% -0.53ms - +0.59ms	-	unsure 🔍 -2% - +2% -0.51ms - +0.67ms
previous-release previous-release	30.31ms - 31.17ms	unsure 🔍 -2% - +2% -0.64ms - +0.53ms	unsure 🔍 -2% - +2% -0.67ms - +0.51ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	472.23ms - 483.42ms	-	unsure 🔍 -2% - +1% -9.31ms - +6.28ms	unsure 🔍 -2% - +1% -11.76ms - +4.91ms
tip-of-tree tip-of-tree	473.91ms - 484.77ms	unsure 🔍 -1% - +2% -6.28ms - +9.31ms	-	unsure 🔍 -2% - +1% -10.14ms - +6.32ms
previous-release previous-release	475.07ms - 487.43ms	unsure 🔍 -1% - +2% -4.91ms - +11.76ms	unsure 🔍 -1% - +2% -6.32ms - +10.14ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	512.63ms - 524.20ms	-	unsure 🔍 -1% - +2% -5.93ms - +10.04ms	unsure 🔍 -2% - +2% -8.31ms - +8.21ms
tip-of-tree tip-of-tree	510.85ms - 521.86ms	unsure 🔍 -2% - +1% -10.04ms - +5.93ms	-	unsure 🔍 -2% - +1% -10.17ms - +5.96ms
previous-release previous-release	512.57ms - 524.36ms	unsure 🔍 -2% - +2% -8.21ms - +8.31ms	unsure 🔍 -1% - +2% -5.96ms - +10.17ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2024-06-23T22:14:48Z

The size of lit-html.js and lit-core.min.js are as expected.

justinfagnani · 2024-06-23T22:16:43Z

Interesting - this adds 231 to lit-core.min.js. I think we'll still want to update dependencies, but understand what's going on here. Maybe @rollup/plugin-terser has some different defaults than rollup-plugin-terser did?

packages/tests/src/utils/assert-goldens.ts

+    // Windows cannot find file `npx` and it's no longer possible to specify
+    // `npx.cmd` https://github.com/nodejs/node/commit/9095c914ed
+    if (/^win/.test(process.platform)) {
+      execSync(`npx ${args.join(' ')}`);


augustjk · 2024-06-24T10:23:54Z

Manual inspection of the bundle shows the difference in bytes are due to some variable names being minified to 2 chars instead of 1. It seems to be variation from the change in the version of the terser packaged used by the rollup plugin. I updated the underlying terser package to latest as well which reduced the size gain a bit to 217 bytes instead of 231.

The failing tests were due to the @rollup/plugin-place not actually replacing the DEV_MODE flag for the bundled polyfill-support.js. Setting preventAssignment: false seems to make it work again. Not entirely sure why, maybe related to it being declared with var, but I didn't want to dig too further.

I also updated the rollup and related packages for the localize examples and starter kits.

justinfagnani · 2024-06-24T18:04:23Z

.changeset/tender-penguins-admire.md

@@ -0,0 +1,2 @@
+---
+---


@augustjk I suppose we should include the starter kits here, since updating dev dependencies is more relevant than for our own packages.

I so wonder if we should mention the rollup and terser updates for our packages as well though, since conceivably they could effect people if something goes wrong. wdyt?

justinfagnani

Your changes LGTM @augustjk. Thanks!

packages/lit-html/package.json

* Fixes #4655 -- Move localize setup to resolve import loop Localize has an import loop, because submodules are importing from their root. To resolve this `msg`, `installed` and `_installMsgImplementation` have moved to a new submodule. Imports to `msg` stay intact, through an explicit export.

[all] Update Rollup packages

df7126c

justinfagnani requested a review from kevinpschaaf as a code owner June 23, 2024 22:12

justinfagnani requested review from augustjk and rictic June 23, 2024 22:17

justinfagnani mentioned this pull request Jun 23, 2024

[all] Update typescript to 5.5.0 #4682

Merged

github-advanced-security bot found potential problems Jun 24, 2024

View reviewed changes

justinfagnani commented Jun 24, 2024

View reviewed changes

packages/lit-html/package.json Show resolved Hide resolved

augustjk approved these changes Jun 24, 2024

View reviewed changes

augustjk and others added 7 commits June 24, 2024 15:02

Update rollup packages for localize example and starter kits

85eca73

Fix test util running on local mac

1c0d93d

Fix wireit config for lit-html compiled test

2dd24b5

Update terser

c45d16f

Fix rollup replace config for bundles

087b490

Update check-size bundle sizes

3a7d6cd

justinfagnani force-pushed the update-rollup branch from abef13d to 3a7d6cd Compare June 24, 2024 22:02

justinfagnani merged commit 4974227 into main Jun 24, 2024

justinfagnani deleted the update-rollup branch June 24, 2024 22:37

lit-robot mentioned this pull request Jul 31, 2024

Version Packages #4718

Merged

augustjk mentioned this pull request Aug 1, 2024

[chore] Update expected sizes #4720

Merged

justinfagnani mentioned this pull request Oct 2, 2024

[all] Revert Rollup Terser plugin to rollup-plugin-terser #4782

Merged

		@@ -0,0 +1,2 @@
		---
		---

Conversation

justinfagnani commented Jun 23, 2024

Uh oh!

changeset-bot bot commented Jun 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Jun 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

github-actions bot commented Jun 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinfagnani commented Jun 23, 2024

Uh oh!

Check warning

augustjk commented Jun 24, 2024

Uh oh!

justinfagnani Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

justinfagnani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Jun 23, 2024 •

edited

Loading

github-actions bot commented Jun 23, 2024 •

edited

Loading

github-actions bot commented Jun 23, 2024 •

edited

Loading