Skip to content

[do not merge] Use subpath pattern to clean up package.json#4483

Closed
AndrewJakubowicz wants to merge 1 commit intomainfrom
package-export-cleanup
Closed

[do not merge] Use subpath pattern to clean up package.json#4483
AndrewJakubowicz wants to merge 1 commit intomainfrom
package-export-cleanup

Conversation

@AndrewJakubowicz
Copy link
Copy Markdown
Contributor

@AndrewJakubowicz AndrewJakubowicz commented Jan 9, 2024

Context

This PR was prompted by the discussion around #4446. If we're going to keep fleshing out the exports, it would have been nice to collapse some of them.

Blockers

Unfortunately JS tooling is not quite there for this PR to be landed.

All dependencies must be past @rollup/node-resolve-plugin version 15.2.1 which includes: rollup/plugins#1549

I think enhanced-resolve, used by the ssr package may not yet support subpath patterns, but I need to investigate that further.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 9, 2024

⚠️ No Changeset found

Latest commit: 6fdc0c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +6% (-0.38ms - +0.62ms)
    this-change vs tip-of-tree

render

  • this-change: 46.95ms - 49.27ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +4% (-0.40ms - +0.80ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.63ms - +0.62ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +3% (-0.15ms - +1.09ms)
    this-change vs tip-of-tree

update

  • this-change: 506.90ms - 513.58ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +8% (-1.75ms - +3.13ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-1.07ms - +1.02ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-1.56ms - +8.67ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 510.17ms - 515.73ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-5.40ms - +4.10ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
46.95ms - 49.27ms-

update

VersionAvg timevs
506.90ms - 513.58ms-

update-reflect

VersionAvg timevs
510.17ms - 515.73ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.26ms - 19.14ms-unsure 🔍
-2% - +4%
-0.40ms - +0.80ms		unsure 🔍
-3% - +4%
-0.54ms - +0.73ms
tip-of-tree
tip-of-tree		18.10ms - 18.90msunsure 🔍
-4% - +2%
-0.80ms - +0.40ms		-unsure 🔍
-4% - +3%
-0.71ms - +0.50ms
previous-release
previous-release		18.15ms - 19.06msunsure 🔍
-4% - +3%
-0.73ms - +0.54ms		unsure 🔍
-3% - +4%
-0.50ms - +0.71ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
38.79ms - 42.10ms-unsure 🔍
-4% - +8%
-1.75ms - +3.13ms		unsure 🔍
-9% - +2%
-3.60ms - +1.05ms
tip-of-tree
tip-of-tree		37.95ms - 41.55msunsure 🔍
-8% - +4%
-3.13ms - +1.75ms		-unsure 🔍
-10% - +1%
-4.40ms - +0.46ms
previous-release
previous-release		40.08ms - 43.36msunsure 🔍
-3% - +9%
-1.05ms - +3.60ms		unsure 🔍
-1% - +11%
-0.46ms - +4.40ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
10.96ms - 11.62ms-unsure 🔍
-3% - +6%
-0.38ms - +0.62ms		unsure 🔍
-7% - +0%
-0.82ms - +0.02ms
tip-of-tree
tip-of-tree		10.80ms - 11.54msunsure 🔍
-5% - +3%
-0.62ms - +0.38ms		-faster ✔
1% - 8%
0.06ms - 0.98ms
previous-release
previous-release		11.43ms - 11.95msunsure 🔍
-0% - +7%
-0.02ms - +0.82ms		slower ❌
0% - 9%
0.06ms - 0.98ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
32.76ms - 33.61ms-unsure 🔍
-2% - +2%
-0.63ms - +0.62ms		unsure 🔍
-2% - +2%
-0.66ms - +0.60ms
tip-of-tree
tip-of-tree		32.73ms - 33.65msunsure 🔍
-2% - +2%
-0.62ms - +0.63ms		-unsure 🔍
-2% - +2%
-0.68ms - +0.63ms
previous-release
previous-release		32.75ms - 33.68msunsure 🔍
-2% - +2%
-0.60ms - +0.66ms		unsure 🔍
-2% - +2%
-0.63ms - +0.68ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
67.94ms - 69.42ms-unsure 🔍
-2% - +1%
-1.07ms - +1.02ms		unsure 🔍
-2% - +1%
-1.28ms - +0.94ms
tip-of-tree
tip-of-tree		67.96ms - 69.44msunsure 🔍
-1% - +2%
-1.02ms - +1.07ms		-unsure 🔍
-2% - +1%
-1.26ms - +0.97ms
previous-release
previous-release		68.01ms - 69.67msunsure 🔍
-1% - +2%
-0.94ms - +1.28ms		unsure 🔍
-1% - +2%
-0.97ms - +1.26ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
33.93ms - 34.81ms-unsure 🔍
-0% - +3%
-0.15ms - +1.09ms		unsure 🔍
-4% - +1%
-1.29ms - +0.30ms
tip-of-tree
tip-of-tree		33.46ms - 34.34msunsure 🔍
-3% - +0%
-1.09ms - +0.15ms		-faster ✔
1% - 5%
0.17ms - 1.76ms
previous-release
previous-release		34.20ms - 35.53msunsure 🔍
-1% - +4%
-0.30ms - +1.29ms		slower ❌
0% - 5%
0.17ms - 1.76ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
525.13ms - 532.49ms-unsure 🔍
-0% - +2%
-1.56ms - +8.67ms		unsure 🔍
-1% - +1%
-6.01ms - +6.21ms
tip-of-tree
tip-of-tree		521.70ms - 528.81msunsure 🔍
-2% - +0%
-8.67ms - +1.56ms		-unsure 🔍
-2% - +0%
-9.49ms - +2.58ms
previous-release
previous-release		523.83ms - 533.59msunsure 🔍
-1% - +1%
-6.21ms - +6.01ms		unsure 🔍
-0% - +2%
-2.58ms - +9.49ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
529.10ms - 536.09ms-unsure 🔍
-1% - +1%
-5.40ms - +4.10ms		unsure 🔍
-1% - +1%
-6.86ms - +3.46ms
tip-of-tree
tip-of-tree		530.04ms - 536.46msunsure 🔍
-1% - +1%
-4.10ms - +5.40ms		-unsure 🔍
-1% - +1%
-6.02ms - +3.92ms
previous-release
previous-release		530.51ms - 538.09msunsure 🔍
-1% - +1%
-3.46ms - +6.86ms		unsure 🔍
-1% - +1%
-3.92ms - +6.02ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2024

The size of lit-html.js and lit-core.min.js are as expected.

@AndrewJakubowicz AndrewJakubowicz mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf will be requested when the pull request is marked ready for review kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AndrewJakubowicz