Fix SSR truncated response by robak86 · Pull Request #4196 · lit/lit

robak86 · 2023-09-16T11:35:27Z

…pressure

changeset-bot · 2023-09-16T11:35:29Z

🦋 Changeset detected

Latest commit: 78b8fc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/ssr	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-cla · 2023-09-16T11:35:31Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

github-actions · 2023-09-16T11:35:43Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +8% (-1.57ms - +1.62ms)
^{this-change vs tip-of-tree}

render

this-change: 72.60ms - 76.25ms
this-change, tip-of-tree, previous-release: unsure 🔍 -10% - +7% (-2.85ms - +2.06ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-1.51ms - +0.76ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-1.22ms - +1.29ms)
^{this-change vs tip-of-tree}

update

this-change: 679.21ms - 695.87ms
this-change, tip-of-tree, previous-release: slower ❌ 0% - 8% (0.30ms - 5.31ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-0.84ms - +1.51ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +0% (-7.46ms - +0.35ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 650.00ms - 659.20ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +0% (-5.16ms - +1.27ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 116.0.5845.187
Sample size: 50
Built by: Benchmarks #5497
Commit: 78b8fc9

render

Version	Avg time	vs
	72.60ms - 76.25ms	-

update

Version	Avg time	vs
	679.21ms - 695.87ms	-

update-reflect

Version	Avg time	vs
	650.00ms - 659.20ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 116.0.5845.187
Sample size: 30
Built by: Benchmarks #5497
Commit: 78b8fc9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	27.39ms - 28.90ms	-	unsure 🔍 -10% - +7% -2.85ms - +2.06ms	unsure 🔍 -2% - +6% -0.46ms - +1.60ms
tip-of-tree tip-of-tree	26.20ms - 30.88ms	unsure 🔍 -7% - +10% -2.06ms - +2.85ms	-	unsure 🔍 -5% - +12% -1.47ms - +3.41ms
previous-release previous-release	26.87ms - 28.27ms	unsure 🔍 -6% - +2% -1.60ms - +0.46ms	unsure 🔍 -12% - +5% -3.41ms - +1.47ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	71.80ms - 75.75ms	-	slower ❌ 0% - 8% 0.30ms - 5.31ms	unsure 🔍 -6% - +5% -4.12ms - +3.76ms
tip-of-tree tip-of-tree	69.43ms - 72.51ms	faster ✔ 0% - 7% 0.30ms - 5.31ms	-	unsure 🔍 -9% - +1% -6.72ms - +0.76ms
previous-release previous-release	70.54ms - 77.36ms	unsure 🔍 -5% - +6% -3.76ms - +4.12ms	unsure 🔍 -1% - +10% -0.76ms - +6.72ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.28ms - 20.60ms	-	unsure 🔍 -8% - +8% -1.57ms - +1.62ms	unsure 🔍 -8% - +7% -1.50ms - +1.36ms
tip-of-tree tip-of-tree	18.32ms - 20.51ms	unsure 🔍 -8% - +8% -1.62ms - +1.57ms	-	unsure 🔍 -8% - +7% -1.48ms - +1.29ms
previous-release previous-release	18.67ms - 20.35ms	unsure 🔍 -7% - +8% -1.36ms - +1.50ms	unsure 🔍 -7% - +8% -1.29ms - +1.48ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 116.0.5845.187
Sample size: 50
Built by: Benchmarks #5497
Commit: 78b8fc9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	49.03ms - 50.12ms	-	unsure 🔍 -3% - +2% -1.51ms - +0.76ms	unsure 🔍 -1% - +2% -0.61ms - +0.92ms
tip-of-tree tip-of-tree	48.95ms - 50.95ms	unsure 🔍 -2% - +3% -0.76ms - +1.51ms	-	unsure 🔍 -1% - +3% -0.61ms - +1.67ms
previous-release previous-release	48.88ms - 49.96ms	unsure 🔍 -2% - +1% -0.92ms - +0.61ms	unsure 🔍 -3% - +1% -1.67ms - +0.61ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	104.64ms - 106.54ms	-	unsure 🔍 -1% - +1% -0.84ms - +1.51ms	unsure 🔍 -1% - +1% -0.80ms - +1.56ms
tip-of-tree tip-of-tree	104.56ms - 105.95ms	unsure 🔍 -1% - +1% -1.51ms - +0.84ms	-	unsure 🔍 -1% - +1% -0.95ms - +1.04ms
previous-release previous-release	104.51ms - 105.92ms	unsure 🔍 -1% - +1% -1.56ms - +0.80ms	unsure 🔍 -1% - +1% -1.04ms - +0.95ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 116.0.5845.187
Sample size: 50
Built by: Benchmarks #5497
Commit: 78b8fc9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	42.96ms - 45.25ms	-	unsure 🔍 -3% - +3% -1.22ms - +1.29ms	unsure 🔍 -3% - +3% -1.20ms - +1.30ms
tip-of-tree tip-of-tree	43.55ms - 44.59ms	unsure 🔍 -3% - +3% -1.29ms - +1.22ms	-	unsure 🔍 -2% - +2% -0.71ms - +0.75ms
previous-release previous-release	43.55ms - 44.56ms	unsure 🔍 -3% - +3% -1.30ms - +1.20ms	unsure 🔍 -2% - +2% -0.75ms - +0.71ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	665.13ms - 669.51ms	-	unsure 🔍 -1% - +0% -7.46ms - +0.35ms	unsure 🔍 -1% - +0% -6.28ms - +0.93ms
tip-of-tree tip-of-tree	667.65ms - 674.11ms	unsure 🔍 -0% - +1% -0.35ms - +7.46ms	-	unsure 🔍 -1% - +1% -3.44ms - +5.20ms
previous-release previous-release	667.13ms - 672.87ms	unsure 🔍 -0% - +1% -0.93ms - +6.28ms	unsure 🔍 -1% - +1% -5.20ms - +3.44ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	668.10ms - 672.43ms	-	unsure 🔍 -1% - +0% -5.16ms - +1.27ms	unsure 🔍 -1% - +0% -5.35ms - +0.90ms
tip-of-tree tip-of-tree	669.83ms - 674.59ms	unsure 🔍 -0% - +1% -1.27ms - +5.16ms	-	unsure 🔍 -1% - +0% -3.55ms - +3.00ms
previous-release previous-release	670.24ms - 674.74ms	unsure 🔍 -0% - +1% -0.90ms - +5.35ms	unsure 🔍 -0% - +1% -3.00ms - +3.55ms	-

_{tachometer-reporter-action v2 for Benchmarks}

AndrewJakubowicz

Looks great! Thank you so much! Verified the issue is fixed with this change.

Could you please add a changeset?

packages/labs/ssr/src/test/lib/render-result-readable_test.ts

justinfagnani

Awesome, thanks!!

I have just one small comment

packages/labs/ssr/src/lib/render-result-readable.ts

Persist current iterator across multiple _read calls in case of back …

c79fc09

…pressure

robak86 requested a review from kevinpschaaf as a code owner September 16, 2023 11:35

robak86 changed the title ~~Persist current iterator across multiple _read calls~~ Fix SSR truncated response Sep 16, 2023

AndrewJakubowicz approved these changes Sep 16, 2023

View reviewed changes

packages/labs/ssr/src/test/lib/render-result-readable_test.ts Outdated Show resolved Hide resolved

AndrewJakubowicz requested a review from justinfagnani September 16, 2023 16:18

robak86 added 3 commits September 17, 2023 09:30

Set more meaningful test case description

bc0b182

Add changeset

e8bfac8

Fix formatting

f9f1ce5

justinfagnani approved these changes Sep 18, 2023

View reviewed changes

packages/labs/ssr/src/lib/render-result-readable.ts Outdated Show resolved Hide resolved

Update packages/labs/ssr/src/lib/render-result-readable.ts

78b8fc9

justinfagnani merged commit fb9147b into lit:main Sep 18, 2023

Marbitch mentioned this pull request Sep 18, 2023

[labs/ssr] Truncated response #4187

Closed

lit-robot mentioned this pull request Sep 27, 2023

Version Packages #4229

Merged

Conversation

robak86 commented Sep 16, 2023

Uh oh!

changeset-bot bot commented Sep 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

google-cla bot commented Sep 16, 2023

Uh oh!

github-actions bot commented Sep 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

AndrewJakubowicz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinfagnani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Sep 16, 2023 •

edited

Loading

github-actions bot commented Sep 16, 2023 •

edited

Loading

AndrewJakubowicz left a comment •

edited

Loading