[labs/gen-wrapper-vue] Pin version of `vue-tsc` to ~1.3 by augustjk · Pull Request #3828 · lit/lit

augustjk · 2023-04-21T00:42:53Z

Above issue is causing test failures in the pipeline.

It could be that the generated Vue code needs to be updated to alleviate the type error, but I don't know enough about Vue to tell if that's the correct thing to do. At least this is how it used to work so I'm proposing we pin this for now until we know if the type error seen in the latest version is legit.

changeset-bot · 2023-04-21T00:42:56Z

🦋 Changeset detected

Latest commit: 6bb1d46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/gen-wrapper-vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-04-21T00:43:16Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -9% - +0% (-1.69ms - +0.09ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 75.08ms - 78.04ms
lit-html-kitchen-sink: unsure 🔍 -10% - +2% (-3.16ms - +0.65ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -12% - +0% (-1.31ms - +0.06ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +5% (-0.62ms - +2.70ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -5% - +2% (-2.95ms - +0.84ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 782.35ms - 788.74ms
lit-html-kitchen-sink: unsure 🔍 -5% - +3% (-3.85ms - +2.78ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -10% - +7% (-30.09ms - +21.12ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +2% (-1.97ms - +2.11ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-6.61ms - +6.62ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 758.37ms - 764.47ms
reactive-element-list: unsure 🔍 -1% - +1% (-5.34ms - +6.03ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 112.0.5615.121
Sample size: 50
Built by: Benchmarks #4668
Commit: 797a15e

render

Version	Avg time	vs
	75.08ms - 78.04ms	-

update

Version	Avg time	vs
	782.35ms - 788.74ms	-

update-reflect

Version	Avg time	vs
	758.37ms - 764.47ms	-

lit-html-kitchen-sink

Browser: chrome-headless 112.0.5615.121
Sample size: 30
Built by: Benchmarks #4668
Commit: 797a15e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.64ms - 32.24ms	-	unsure 🔍 -10% - +2% -3.16ms - +0.65ms	unsure 🔍 -8% - +4% -2.68ms - +1.20ms
tip-of-tree tip-of-tree	30.81ms - 33.58ms	unsure 🔍 -2% - +10% -0.65ms - +3.16ms	-	unsure 🔍 -5% - +8% -1.48ms - +2.52ms
previous-release previous-release	30.24ms - 33.11ms	unsure 🔍 -4% - +9% -1.20ms - +2.68ms	unsure 🔍 -8% - +5% -2.52ms - +1.48ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	76.68ms - 81.39ms	-	unsure 🔍 -5% - +3% -3.85ms - +2.78ms	unsure 🔍 -3% - +5% -2.59ms - +3.75ms
tip-of-tree tip-of-tree	77.23ms - 81.91ms	unsure 🔍 -4% - +5% -2.78ms - +3.85ms	-	unsure 🔍 -3% - +5% -2.05ms - +4.28ms
previous-release previous-release	76.32ms - 80.58ms	unsure 🔍 -5% - +3% -3.75ms - +2.59ms	unsure 🔍 -5% - +3% -4.28ms - +2.05ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	16.28ms - 17.03ms	-	unsure 🔍 -9% - +0% -1.69ms - +0.09ms	unsure 🔍 -9% - +2% -1.51ms - +0.33ms
tip-of-tree tip-of-tree	16.65ms - 18.26ms	unsure 🔍 -1% - +10% -0.09ms - +1.69ms	-	unsure 🔍 -6% - +8% -0.95ms - +1.37ms
previous-release previous-release	16.40ms - 18.08ms	unsure 🔍 -2% - +9% -0.33ms - +1.51ms	unsure 🔍 -8% - +5% -1.37ms - +0.95ms	-

lit-html-repeat

Browser: chrome-headless 112.0.5615.121
Sample size: 30
Built by: Benchmarks #4668
Commit: 797a15e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.06ms - 11.09ms	-	unsure 🔍 -12% - +0% -1.31ms - +0.06ms	unsure 🔍 -10% - +3% -1.13ms - +0.38ms
tip-of-tree tip-of-tree	10.75ms - 11.65ms	unsure 🔍 -1% - +13% -0.06ms - +1.31ms	-	unsure 🔍 -4% - +9% -0.47ms - +0.96ms
previous-release previous-release	10.40ms - 11.51ms	unsure 🔍 -4% - +11% -0.38ms - +1.13ms	unsure 🔍 -9% - +4% -0.96ms - +0.47ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	287.58ms - 324.53ms	-	unsure 🔍 -10% - +7% -30.09ms - +21.12ms	unsure 🔍 -10% - +7% -29.82ms - +21.23ms
tip-of-tree tip-of-tree	292.82ms - 328.26ms	unsure 🔍 -7% - +10% -21.12ms - +30.09ms	-	unsure 🔍 -8% - +8% -24.80ms - +25.17ms
previous-release previous-release	292.74ms - 327.97ms	unsure 🔍 -7% - +10% -21.23ms - +29.82ms	unsure 🔍 -8% - +8% -25.17ms - +24.80ms	-

lit-html-template-heavy

Browser: chrome-headless 112.0.5615.121
Sample size: 50
Built by: Benchmarks #4668
Commit: 797a15e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	54.81ms - 57.41ms	-	unsure 🔍 -1% - +5% -0.62ms - +2.70ms	unsure 🔍 -3% - +3% -1.44ms - +1.74ms
tip-of-tree tip-of-tree	54.04ms - 56.10ms	unsure 🔍 -5% - +1% -2.70ms - +0.62ms	-	unsure 🔍 -4% - +1% -2.27ms - +0.49ms
previous-release previous-release	55.04ms - 56.87ms	unsure 🔍 -3% - +3% -1.74ms - +1.44ms	unsure 🔍 -1% - +4% -0.49ms - +2.27ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	114.46ms - 117.12ms	-	unsure 🔍 -2% - +2% -1.97ms - +2.11ms	unsure 🔍 -2% - +2% -2.50ms - +2.23ms
tip-of-tree tip-of-tree	114.17ms - 117.27ms	unsure 🔍 -2% - +2% -2.11ms - +1.97ms	-	unsure 🔍 -2% - +2% -2.70ms - +2.29ms
previous-release previous-release	113.97ms - 117.88ms	unsure 🔍 -2% - +2% -2.23ms - +2.50ms	unsure 🔍 -2% - +2% -2.29ms - +2.70ms	-

reactive-element-list

Browser: chrome-headless 112.0.5615.121
Sample size: 50
Built by: Benchmarks #4668
Commit: 797a15e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	51.22ms - 53.98ms	-	unsure 🔍 -5% - +2% -2.95ms - +0.84ms	unsure 🔍 -6% - +1% -3.10ms - +0.77ms
tip-of-tree tip-of-tree	52.36ms - 54.96ms	unsure 🔍 -2% - +6% -0.84ms - +2.95ms	-	unsure 🔍 -4% - +3% -1.99ms - +1.77ms
previous-release previous-release	52.40ms - 55.13ms	unsure 🔍 -2% - +6% -0.77ms - +3.10ms	unsure 🔍 -3% - +4% -1.77ms - +1.99ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	821.70ms - 829.48ms	-	unsure 🔍 -1% - +1% -6.61ms - +6.62ms	unsure 🔍 -1% - +1% -6.24ms - +5.14ms
tip-of-tree tip-of-tree	820.23ms - 830.93ms	unsure 🔍 -1% - +1% -6.62ms - +6.61ms	-	unsure 🔍 -1% - +1% -7.34ms - +6.22ms
previous-release previous-release	821.99ms - 830.30ms	unsure 🔍 -1% - +1% -5.14ms - +6.24ms	unsure 🔍 -1% - +1% -6.22ms - +7.34ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	810.54ms - 817.94ms	-	unsure 🔍 -1% - +1% -5.34ms - +6.03ms	unsure 🔍 -1% - +0% -7.19ms - +3.78ms
tip-of-tree tip-of-tree	809.58ms - 818.21ms	unsure 🔍 -1% - +1% -6.03ms - +5.34ms	-	unsure 🔍 -1% - +0% -7.97ms - +3.87ms
previous-release previous-release	811.89ms - 820.00ms	unsure 🔍 -0% - +1% -3.78ms - +7.19ms	unsure 🔍 -0% - +1% -3.87ms - +7.97ms	-

_{tachometer-reporter-action v2 for Benchmarks}

augustjk · 2023-04-21T04:56:49Z

This is no longer necessary as vue-tsc has been updated.

augustjk added 2 commits April 20, 2023 17:36

Pin version of vue-tsc to ~1.3

b198df3

Add changeset

6bb1d46

augustjk requested a review from sorvell April 21, 2023 00:42

augustjk requested a review from justinfagnani as a code owner April 21, 2023 00:42

augustjk mentioned this pull request Apr 21, 2023

[lit-html] Static html should not add consumed value to TemplateResult #3825

Merged

justinfagnani approved these changes Apr 21, 2023

View reviewed changes

augustjk closed this Apr 21, 2023

augustjk deleted the gen-wrapper-vue-tsc-pin branch April 27, 2023 23:53

Conversation

augustjk commented Apr 21, 2023

Uh oh!

changeset-bot bot commented Apr 21, 2023

🦋 Changeset detected

Uh oh!

github-actions bot commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

augustjk commented Apr 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Apr 21, 2023 •

edited

Loading