Skip to content

Explicitly annotate the this value of set function#3698

Merged
rictic merged 1 commit intomainfrom
annotate-this-context
Feb 27, 2023
Merged

Explicitly annotate the this value of set function#3698
rictic merged 1 commit intomainfrom
annotate-this-context

Conversation

@rictic
Copy link
Copy Markdown
Collaborator

@rictic rictic commented Feb 27, 2023

This is needed for some internal tooling.

@rictic
Explicitly annotate the this value of set function
29d2159 
This is needed for some internal tooling.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 27, 2023

🦋 Changeset detected

Latest commit: 29d2159

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/context Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 27, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -5% - +5% (-0.98ms - +1.09ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 109.70ms - 114.07ms
  • lit-html-kitchen-sink: slower ❌ 0% - 12% (0.08ms - 5.32ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -6% - +5% (-0.96ms - +0.82ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +3% (-2.02ms - +2.37ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +4% (-0.64ms - +3.34ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 1045.51ms - 1065.70ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +5% (-4.76ms - +5.73ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +5% (-9.29ms - +17.57ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +2% (-4.20ms - +3.51ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +2% (-13.62ms - +17.35ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 1049.30ms - 1064.02ms
  • reactive-element-list: unsure 🔍 -2% - +0% (-25.61ms - +4.89ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
109.70ms - 114.07ms-

update

VersionAvg timevs
1045.51ms - 1065.70ms-

update-reflect

VersionAvg timevs
1049.30ms - 1064.02ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
46.76ms - 50.85ms-slower ❌
0% - 12%
0.08ms - 5.32ms		unsure 🔍
-3% - +8%
-1.52ms - +3.66ms
tip-of-tree
tip-of-tree		44.47ms - 47.75msfaster ✔
0% - 11%
0.08ms - 5.32ms		-unsure 🔍
-8% - +1%
-3.92ms - +0.66ms
previous-release
previous-release		46.14ms - 49.33msunsure 🔍
-7% - +3%
-3.66ms - +1.52ms		unsure 🔍
-2% - +9%
-0.66ms - +3.92ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
111.56ms - 117.09ms-unsure 🔍
-4% - +5%
-4.76ms - +5.73ms		unsure 🔍
-6% - +3%
-6.45ms - +3.61ms
tip-of-tree
tip-of-tree		109.38ms - 118.30msunsure 🔍
-5% - +4%
-5.73ms - +4.76ms		-unsure 🔍
-7% - +4%
-8.03ms - +4.23ms
previous-release
previous-release		111.54ms - 119.95msunsure 🔍
-3% - +6%
-3.61ms - +6.45ms		unsure 🔍
-4% - +7%
-4.23ms - +8.03ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
20.66ms - 21.69ms-unsure 🔍
-5% - +5%
-0.98ms - +1.09ms		unsure 🔍
-3% - +5%
-0.72ms - +1.12ms
tip-of-tree
tip-of-tree		20.22ms - 22.02msunsure 🔍
-5% - +5%
-1.09ms - +0.98ms		-unsure 🔍
-5% - +6%
-1.03ms - +1.33ms
previous-release
previous-release		20.21ms - 21.74msunsure 🔍
-5% - +3%
-1.12ms - +0.72ms		unsure 🔍
-6% - +5%
-1.33ms - +1.03ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
14.62ms - 15.81ms-unsure 🔍
-6% - +5%
-0.96ms - +0.82ms		unsure 🔍
-10% - +2%
-1.55ms - +0.29ms
tip-of-tree
tip-of-tree		14.62ms - 15.94msunsure 🔍
-5% - +6%
-0.82ms - +0.96ms		-unsure 🔍
-10% - +2%
-1.52ms - +0.40ms
previous-release
previous-release		15.14ms - 16.55msunsure 🔍
-2% - +10%
-0.29ms - +1.55ms		unsure 🔍
-3% - +10%
-0.40ms - +1.52ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
356.22ms - 372.07ms-unsure 🔍
-3% - +5%
-9.29ms - +17.57ms		unsure 🔍
-2% - +4%
-6.91ms - +15.44ms
tip-of-tree
tip-of-tree		349.16ms - 370.85msunsure 🔍
-5% - +3%
-17.57ms - +9.29ms		-unsure 🔍
-4% - +4%
-13.28ms - +13.53ms
previous-release
previous-release		352.00ms - 367.75msunsure 🔍
-4% - +2%
-15.44ms - +6.91ms		unsure 🔍
-4% - +4%
-13.53ms - +13.28ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
68.87ms - 71.94ms-unsure 🔍
-3% - +3%
-2.02ms - +2.37ms		unsure 🔍
-2% - +4%
-1.39ms - +2.57ms
tip-of-tree
tip-of-tree		68.66ms - 71.81msunsure 🔍
-3% - +3%
-2.37ms - +2.02ms		-unsure 🔍
-2% - +3%
-1.59ms - +2.42ms
previous-release
previous-release		68.57ms - 71.07msunsure 🔍
-4% - +2%
-2.57ms - +1.39ms		unsure 🔍
-3% - +2%
-2.42ms - +1.59ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
143.48ms - 148.51ms-unsure 🔍
-3% - +2%
-4.20ms - +3.51ms		unsure 🔍
-3% - +1%
-4.46ms - +1.87ms
tip-of-tree
tip-of-tree		143.42ms - 149.26msunsure 🔍
-2% - +3%
-3.51ms - +4.20ms		-unsure 🔍
-3% - +2%
-4.44ms - +2.54ms
previous-release
previous-release		145.37ms - 149.21msunsure 🔍
-1% - +3%
-1.87ms - +4.46ms		unsure 🔍
-2% - +3%
-2.54ms - +4.44ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
79.07ms - 82.03ms-unsure 🔍
-1% - +4%
-0.64ms - +3.34ms		unsure 🔍
-0% - +5%
-0.28ms - +3.58ms
tip-of-tree
tip-of-tree		77.87ms - 80.54msunsure 🔍
-4% - +1%
-3.34ms - +0.64ms		-unsure 🔍
-2% - +3%
-1.52ms - +2.12ms
previous-release
previous-release		77.66ms - 80.14msunsure 🔍
-4% - +0%
-3.58ms - +0.28ms		unsure 🔍
-3% - +2%
-2.12ms - +1.52ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1081.81ms - 1103.36ms-unsure 🔍
-1% - +2%
-13.62ms - +17.35ms		unsure 🔍
-1% - +1%
-13.55ms - +13.67ms
tip-of-tree
tip-of-tree		1079.60ms - 1101.84msunsure 🔍
-2% - +1%
-17.35ms - +13.62ms		-unsure 🔍
-1% - +1%
-15.69ms - +12.08ms
previous-release
previous-release		1084.21ms - 1100.84msunsure 🔍
-1% - +1%
-13.67ms - +13.55ms		unsure 🔍
-1% - +1%
-12.08ms - +15.69ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1118.57ms - 1140.07ms-unsure 🔍
-2% - +0%
-25.61ms - +4.89ms		unsure 🔍
-1% - +1%
-15.56ms - +14.18ms
tip-of-tree
tip-of-tree		1128.87ms - 1150.49msunsure 🔍
-0% - +2%
-4.89ms - +25.61ms		-unsure 🔍
-0% - +2%
-5.25ms - +24.58ms
previous-release
previous-release		1119.74ms - 1140.29msunsure 🔍
-1% - +1%
-14.18ms - +15.56ms		unsure 🔍
-2% - +0%
-24.58ms - +5.25ms		-

tachometer-reporter-action v2 for Benchmarks

@rictic rictic merged commit b9c27c5 into main Feb 27, 2023
@rictic rictic deleted the annotate-this-context branch February 27, 2023 16:44
@lit-robot lit-robot mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aomarks aomarks aomarks approved these changes

@justinfagnani justinfagnani justinfagnani approved these changes

@benjamind benjamind Awaiting requested review from benjamind benjamind is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rictic @aomarks @justinfagnani