Skip to content

Don't throw if ChildPart.parentNode is null#3615

Merged
justinfagnani merged 2 commits intomainfrom
part-parent-node
Feb 2, 2023
Merged

Don't throw if ChildPart.parentNode is null#3615
justinfagnani merged 2 commits intomainfrom
part-parent-node

Conversation

@justinfagnani
Copy link
Copy Markdown
Collaborator

@justinfagnani justinfagnani commented Jan 27, 2023

Fixes #3611

This seems like it should be a rare edge-case, but a user hit it. The part parent needs to be non-null and the part's parent node needs to be null to hit the issue.

@justinfagnani justinfagnani requested a review from sorvell January 27, 2023 18:47
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 27, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 591a807

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lit-html Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 27, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -17% - +6% (-5.76ms - +2.16ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 87.38ms - 90.44ms
  • lit-html-kitchen-sink: unsure 🔍 -7% - +5% (-2.74ms - +2.16ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -6% - +3% (-0.89ms - +0.45ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.70ms - +1.53ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +1% (-1.80ms - +0.58ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 892.11ms - 900.43ms
  • lit-html-kitchen-sink: unsure 🔍 -9% - +10% (-9.46ms - +10.00ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +1% (-8.35ms - +5.52ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -0% - +2% (-0.13ms - +2.45ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-5.32ms - +6.26ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 890.41ms - 897.39ms
  • reactive-element-list: unsure 🔍 -1% - +1% (-7.38ms - +6.92ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
87.38ms - 90.44ms-

update

VersionAvg timevs
892.11ms - 900.43ms-

update-reflect

VersionAvg timevs
890.41ms - 897.39ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.87ms - 41.07ms-unsure 🔍
-7% - +5%
-2.74ms - +2.16ms		unsure 🔍
-8% - +5%
-3.34ms - +2.17ms
tip-of-tree
tip-of-tree		37.90ms - 41.62msunsure 🔍
-6% - +7%
-2.16ms - +2.74ms		-unsure 🔍
-8% - +7%
-3.21ms - +2.62ms
previous-release
previous-release		37.80ms - 42.30msunsure 🔍
-6% - +8%
-2.17ms - +3.34ms		unsure 🔍
-7% - +8%
-2.62ms - +3.21ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
98.05ms - 111.64ms-unsure 🔍
-9% - +10%
-9.46ms - +10.00ms		unsure 🔍
-9% - +9%
-9.07ms - +9.73ms
tip-of-tree
tip-of-tree		97.61ms - 111.54msunsure 🔍
-10% - +9%
-10.00ms - +9.46ms		-unsure 🔍
-9% - +9%
-9.45ms - +9.58ms
previous-release
previous-release		98.03ms - 111.00msunsure 🔍
-9% - +9%
-9.73ms - +9.07ms		unsure 🔍
-9% - +9%
-9.58ms - +9.45ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
28.88ms - 34.40ms-unsure 🔍
-17% - +6%
-5.76ms - +2.16ms		unsure 🔍
-15% - +10%
-4.85ms - +3.25ms
tip-of-tree
tip-of-tree		30.60ms - 36.27msunsure 🔍
-7% - +19%
-2.16ms - +5.76ms		-unsure 🔍
-10% - +16%
-3.10ms - +5.10ms
previous-release
previous-release		29.47ms - 35.40msunsure 🔍
-10% - +15%
-3.25ms - +4.85ms		unsure 🔍
-15% - +9%
-5.10ms - +3.10ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
13.51ms - 14.45ms-unsure 🔍
-6% - +3%
-0.89ms - +0.45ms		unsure 🔍
-4% - +6%
-0.50ms - +0.83ms
tip-of-tree
tip-of-tree		13.73ms - 14.67msunsure 🔍
-3% - +6%
-0.45ms - +0.89ms		-unsure 🔍
-2% - +8%
-0.29ms - +1.06ms
previous-release
previous-release		13.34ms - 14.29msunsure 🔍
-6% - +4%
-0.83ms - +0.50ms		unsure 🔍
-7% - +2%
-1.06ms - +0.29ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
364.01ms - 374.09ms-unsure 🔍
-2% - +1%
-8.35ms - +5.52ms		unsure 🔍
-1% - +3%
-4.30ms - +9.44ms
tip-of-tree
tip-of-tree		365.71ms - 375.23msunsure 🔍
-1% - +2%
-5.52ms - +8.35ms		-unsure 🔍
-1% - +3%
-2.68ms - +10.65ms
previous-release
previous-release		361.82ms - 371.15msunsure 🔍
-3% - +1%
-9.44ms - +4.30ms		unsure 🔍
-3% - +1%
-10.65ms - +2.68ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
62.43ms - 64.01ms-unsure 🔍
-1% - +2%
-0.70ms - +1.53ms		unsure 🔍
-1% - +2%
-0.92ms - +1.35ms
tip-of-tree
tip-of-tree		62.03ms - 63.59msunsure 🔍
-2% - +1%
-1.53ms - +0.70ms		-unsure 🔍
-2% - +1%
-1.32ms - +0.92ms
previous-release
previous-release		62.20ms - 63.82msunsure 🔍
-2% - +1%
-1.35ms - +0.92ms		unsure 🔍
-1% - +2%
-0.92ms - +1.32ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
134.16ms - 135.98ms-unsure 🔍
-0% - +2%
-0.13ms - +2.45ms		unsure 🔍
-1% - +2%
-1.93ms - +2.23ms
tip-of-tree
tip-of-tree		133.00ms - 134.83msunsure 🔍
-2% - +0%
-2.45ms - +0.13ms		-unsure 🔍
-2% - +1%
-3.08ms - +1.07ms
previous-release
previous-release		133.06ms - 136.79msunsure 🔍
-2% - +1%
-2.23ms - +1.93ms		unsure 🔍
-1% - +2%
-1.07ms - +3.08ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
59.53ms - 61.04ms-unsure 🔍
-3% - +1%
-1.80ms - +0.58ms		unsure 🔍
-4% - +0%
-2.19ms - +0.29ms
tip-of-tree
tip-of-tree		59.97ms - 61.81msunsure 🔍
-1% - +3%
-0.58ms - +1.80ms		-unsure 🔍
-3% - +2%
-1.69ms - +1.00ms
previous-release
previous-release		60.26ms - 62.21msunsure 🔍
-0% - +4%
-0.29ms - +2.19ms		unsure 🔍
-2% - +3%
-1.00ms - +1.69ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
915.11ms - 923.18ms-unsure 🔍
-1% - +1%
-5.32ms - +6.26ms		unsure 🔍
-1% - +1%
-5.36ms - +5.68ms
tip-of-tree
tip-of-tree		914.52ms - 922.82msunsure 🔍
-1% - +1%
-6.26ms - +5.32ms		-unsure 🔍
-1% - +1%
-5.91ms - +5.29ms
previous-release
previous-release		915.22ms - 922.74msunsure 🔍
-1% - +1%
-5.68ms - +5.36ms		unsure 🔍
-1% - +1%
-5.29ms - +5.91ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
931.49ms - 942.11ms-unsure 🔍
-1% - +1%
-7.38ms - +6.92ms		unsure 🔍
-1% - +0%
-10.06ms - +4.05ms
tip-of-tree
tip-of-tree		932.24ms - 941.82msunsure 🔍
-1% - +1%
-6.92ms - +7.38ms		-unsure 🔍
-1% - +0%
-9.45ms - +3.90ms
previous-release
previous-release		935.16ms - 944.45msunsure 🔍
-0% - +1%
-4.05ms - +10.06ms		unsure 🔍
-0% - +1%
-3.90ms - +9.45ms		-

tachometer-reporter-action v2 for Benchmarks

augustjk
augustjk reviewed Jan 27, 2023
View reviewed changes
@justinfagnani @augustjk
Update .changeset/early-snakes-complain.md
591a807 
Co-authored-by: Augustine Kim <augustinekim@google.com>
@justinfagnani justinfagnani merged commit 4d69843 into main Feb 2, 2023
@justinfagnani justinfagnani deleted the part-parent-node branch February 2, 2023 00:00
@lit-robot lit-robot mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustjk augustjk augustjk left review comments

@sorvell sorvell sorvell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[lit-html] get ParentNode should handle when parentNode is null

3 participants

@justinfagnani @sorvell @augustjk