Skip to content

[SSR] Add shadowrootmode forwards compat#3599

Merged
e111077 merged 3 commits intomainfrom
lit-ssr-shadowrootmode
Jan 23, 2023
Merged

[SSR] Add shadowrootmode forwards compat#3599
e111077 merged 3 commits intomainfrom
lit-ssr-shadowrootmode

Conversation

@e111077
Copy link
Copy Markdown
Contributor

@e111077 e111077 commented Jan 23, 2023

Adding forwards compatibility with the shadowroot -> shadowrootmode breaking change (link to intent to ship) Or maybe we just wait until it's shipped in something behind a flag

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 23, 2023

🦋 Changeset detected

Latest commit: f3ff74f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/ssr Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2023

📊 Tachometer Benchmark Results

Summary

  • lit-element-list
  • lit-html-kitchen-sink
  • lit-html-repeat
  • lit-html-template-heavy
  • reactive-element-list

Results

tachometer-reporter-action v2 for Benchmarks

@e111077 e111077 marked this pull request as ready for review January 23, 2023 20:54
@e111077
Copy link
Copy Markdown
Contributor Author

e111077 commented Jan 23, 2023

No idea what's going on with those failures. Seem unrelated

Copy link
Copy Markdown
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@e111077 e111077 enabled auto-merge (squash) January 23, 2023 21:52
@e111077 e111077 disabled auto-merge January 23, 2023 21:52
@e111077
Copy link
Copy Markdown
Contributor Author

e111077 commented Jan 23, 2023

Can't seem to merge because of windows-tools test failures. any idea what to do there?

@e111077 e111077 merged commit ca74ff6 into main Jan 23, 2023
@e111077 e111077 deleted the lit-ssr-shadowrootmode branch January 23, 2023 22:03
@lit-robot lit-robot mentioned this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants