[lit-html, reactive-element] Add development node builds by augustjk · Pull Request #3495 · lit/lit

augustjk · 2022-12-06T05:04:02Z

While working on SSR integration, it was found that dev mode was using the unminified development build of lit-element but using the minified Node build of reactive-element causing error due to the mismatching method names.

This is solved by adding a development Node build which is unminified and will be used in these cases.

changeset-bot · 2022-12-06T05:04:05Z

🦋 Changeset detected

Latest commit: 8f88386

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
lit-html	Minor
@lit/reactive-element	Minor
lit	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-12-06T05:04:28Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -3% - +3% (-0.92ms - +0.90ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 98.28ms - 106.31ms
lit-html-kitchen-sink: unsure 🔍 -1% - +7% (-0.43ms - +2.81ms)
^{this-change vs tip-of-tree}
lit-html-repeat: slower ❌ 1% - 14% (0.11ms - 1.92ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +1% (-2.37ms - +0.72ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -4% - +3% (-2.70ms - +1.85ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 912.81ms - 930.51ms
lit-html-kitchen-sink: unsure 🔍 -7% - +0% (-7.12ms - +0.49ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -2% - +3% (-7.58ms - +10.36ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +1% (-4.86ms - +0.92ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-13.94ms - +12.37ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 912.44ms - 926.03ms
reactive-element-list: unsure 🔍 -2% - +1% (-14.62ms - +9.01ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 107.0.5304.121
Sample size: 50
Built by: Benchmarks #4146
Commit: 2713619

render

Version	Avg time	vs
	98.28ms - 106.31ms	-

update

Version	Avg time	vs
	912.81ms - 930.51ms	-

update-reflect

Version	Avg time	vs
	912.44ms - 926.03ms	-

lit-html-kitchen-sink

Browser: chrome-headless 107.0.5304.121
Sample size: 30
Built by: Benchmarks #4146
Commit: 2713619

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	37.84ms - 40.17ms	-	unsure 🔍 -1% - +7% -0.43ms - +2.81ms	unsure 🔍 -3% - +7% -1.29ms - +2.67ms
tip-of-tree tip-of-tree	36.70ms - 38.94ms	unsure 🔍 -7% - +1% -2.81ms - +0.43ms	-	unsure 🔍 -6% - +4% -2.45ms - +1.46ms
previous-release previous-release	36.71ms - 39.91ms	unsure 🔍 -7% - +3% -2.67ms - +1.29ms	unsure 🔍 -4% - +6% -1.46ms - +2.45ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	98.22ms - 103.15ms	-	unsure 🔍 -7% - +0% -7.12ms - +0.49ms	unsure 🔍 -5% - +3% -4.90ms - +3.05ms
tip-of-tree tip-of-tree	101.10ms - 106.90ms	unsure 🔍 -1% - +7% -0.49ms - +7.12ms	-	unsure 🔍 -2% - +7% -1.86ms - +6.64ms
previous-release previous-release	98.50ms - 104.72ms	unsure 🔍 -3% - +5% -3.05ms - +4.90ms	unsure 🔍 -6% - +2% -6.64ms - +1.86ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	26.17ms - 27.34ms	-	unsure 🔍 -3% - +3% -0.92ms - +0.90ms	unsure 🔍 -3% - +4% -0.85ms - +1.02ms
tip-of-tree tip-of-tree	26.07ms - 27.46ms	unsure 🔍 -3% - +3% -0.90ms - +0.92ms	-	unsure 🔍 -3% - +4% -0.91ms - +1.10ms
previous-release previous-release	25.94ms - 27.40ms	unsure 🔍 -4% - +3% -1.02ms - +0.85ms	unsure 🔍 -4% - +3% -1.10ms - +0.91ms	-

lit-html-repeat

Browser: chrome-headless 107.0.5304.121
Sample size: 30
Built by: Benchmarks #4146
Commit: 2713619

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	14.08ms - 15.67ms	-	slower ❌ 1% - 14% 0.11ms - 1.92ms	unsure 🔍 -2% - +12% -0.24ms - +1.67ms
tip-of-tree tip-of-tree	13.43ms - 14.30ms	faster ✔ 1% - 13% 0.11ms - 1.92ms	-	unsure 🔍 -7% - +3% -0.98ms - +0.39ms
previous-release previous-release	13.63ms - 14.69ms	unsure 🔍 -11% - +1% -1.67ms - +0.24ms	unsure 🔍 -3% - +7% -0.39ms - +0.98ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	370.58ms - 383.62ms	-	unsure 🔍 -2% - +3% -7.58ms - +10.36ms	unsure 🔍 -1% - +3% -4.92ms - +12.46ms
tip-of-tree tip-of-tree	369.55ms - 381.87ms	unsure 🔍 -3% - +2% -10.36ms - +7.58ms	-	unsure 🔍 -2% - +3% -6.05ms - +10.80ms
previous-release previous-release	367.58ms - 379.08ms	unsure 🔍 -3% - +1% -12.46ms - +4.92ms	unsure 🔍 -3% - +2% -10.80ms - +6.05ms	-

lit-html-template-heavy

Browser: chrome-headless 107.0.5304.121
Sample size: 50
Built by: Benchmarks #4146
Commit: 2713619

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	65.54ms - 67.65ms	-	unsure 🔍 -3% - +1% -2.37ms - +0.72ms	unsure 🔍 -4% - +1% -2.55ms - +0.50ms
tip-of-tree tip-of-tree	66.30ms - 68.54ms	unsure 🔍 -1% - +4% -0.72ms - +2.37ms	-	unsure 🔍 -3% - +2% -1.77ms - +1.37ms
previous-release previous-release	66.52ms - 68.72ms	unsure 🔍 -1% - +4% -0.50ms - +2.55ms	unsure 🔍 -2% - +3% -1.37ms - +1.77ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	140.47ms - 144.46ms	-	unsure 🔍 -3% - +1% -4.86ms - +0.92ms	unsure 🔍 -2% - +1% -3.40ms - +2.07ms
tip-of-tree tip-of-tree	142.34ms - 146.52ms	unsure 🔍 -1% - +3% -0.92ms - +4.86ms	-	unsure 🔍 -1% - +3% -1.50ms - +4.11ms
previous-release previous-release	141.25ms - 145.00ms	unsure 🔍 -1% - +2% -2.07ms - +3.40ms	unsure 🔍 -3% - +1% -4.11ms - +1.50ms	-

reactive-element-list

Browser: chrome-headless 107.0.5304.121
Sample size: 50
Built by: Benchmarks #4146
Commit: 2713619

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	63.48ms - 66.17ms	-	unsure 🔍 -4% - +3% -2.70ms - +1.85ms	unsure 🔍 -2% - +5% -1.24ms - +2.87ms
tip-of-tree tip-of-tree	63.41ms - 67.08ms	unsure 🔍 -3% - +4% -1.85ms - +2.70ms	-	unsure 🔍 -2% - +6% -1.17ms - +3.64ms
previous-release previous-release	62.45ms - 65.57ms	unsure 🔍 -4% - +2% -2.87ms - +1.24ms	unsure 🔍 -6% - +2% -3.64ms - +1.17ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	920.95ms - 940.91ms	-	unsure 🔍 -1% - +1% -13.94ms - +12.37ms	unsure 🔍 -1% - +1% -12.53ms - +13.65ms
tip-of-tree tip-of-tree	923.14ms - 940.28ms	unsure 🔍 -1% - +1% -12.37ms - +13.94ms	-	unsure 🔍 -1% - +1% -10.70ms - +13.39ms
previous-release previous-release	921.91ms - 938.83ms	unsure 🔍 -1% - +1% -13.65ms - +12.53ms	unsure 🔍 -1% - +1% -13.39ms - +10.70ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	937.06ms - 953.69ms	-	unsure 🔍 -2% - +1% -14.62ms - +9.01ms	unsure 🔍 -2% - +1% -15.74ms - +8.88ms
tip-of-tree tip-of-tree	939.78ms - 956.57ms	unsure 🔍 -1% - +2% -9.01ms - +14.62ms	-	unsure 🔍 -1% - +1% -12.99ms - +11.74ms
previous-release previous-release	939.72ms - 957.88ms	unsure 🔍 -1% - +2% -8.88ms - +15.74ms	unsure 🔍 -1% - +1% -11.74ms - +12.99ms	-

_{tachometer-reporter-action v2 for Benchmarks}

.changeset/light-dryers-talk.md

rollup-common.js

Co-authored-by: Alexander Marks <aomarks@google.com>

Add development node builds

64cc68f

augustjk requested a review from aomarks December 6, 2022 05:04

augustjk requested a review from justinfagnani as a code owner December 6, 2022 05:04

aomarks approved these changes Dec 6, 2022

View reviewed changes

.changeset/light-dryers-talk.md Outdated Show resolved Hide resolved

rollup-common.js Outdated Show resolved Hide resolved

augustjk and others added 2 commits December 7, 2022 05:33

Fix typo in rollup-common.js

4c6f9cf

Co-authored-by: Alexander Marks <aomarks@google.com>

Update changeset

8f88386

aomarks approved these changes Dec 6, 2022

View reviewed changes

augustjk merged commit e729f18 into main Dec 7, 2022

augustjk deleted the node-dev-build branch December 7, 2022 19:57

This was referenced Dec 7, 2022

Version Packages #3504

Closed

Version Packages #3506

Merged

augustjk mentioned this pull request Dec 16, 2022

disabled shadydom in node dev build #3526

Merged

Conversation

augustjk commented Dec 6, 2022

Uh oh!

changeset-bot bot commented Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Dec 6, 2022 •

edited

Loading

github-actions bot commented Dec 6, 2022 •

edited

Loading