[CLI] `lit init` address remaining suggestions by e111077 · Pull Request #3456 · lit/lit

e111077 · 2022-11-15T00:40:33Z

Implement post-submit suggestions from #3248.

Changed --dir to --out
Removed excess ternary
no longer using .npmignore but rather package.json's files field

changeset-bot · 2022-11-15T00:40:36Z

🦋 Changeset detected

Latest commit: fdb440b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/cli	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-11-15T00:40:51Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: faster ✔ 1% - 9% (0.12ms - 2.22ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 84.20ms - 87.73ms
lit-html-kitchen-sink: unsure 🔍 -4% - +4% (-1.41ms - +1.34ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -5% - +4% (-0.62ms - +0.48ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +2% (-1.44ms - +1.07ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -3% - +3% (-1.63ms - +1.83ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 798.50ms - 806.38ms
lit-html-kitchen-sink: unsure 🔍 -2% - +5% (-1.72ms - +4.24ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -0% - +4% (-0.17ms - +13.24ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +1% (-3.11ms - +1.10ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-5.62ms - +10.68ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 799.97ms - 806.22ms
reactive-element-list: unsure 🔍 -1% - +1% (-7.47ms - +7.07ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 107.0.5304.121
Sample size: 50
Built by: Benchmarks #4119
Commit: fcd32ba

render

Version	Avg time	vs
	84.20ms - 87.73ms	-

update

Version	Avg time	vs
	798.50ms - 806.38ms	-

update-reflect

Version	Avg time	vs
	799.97ms - 806.22ms	-

lit-html-kitchen-sink

Browser: chrome-headless 107.0.5304.121
Sample size: 30
Built by: Benchmarks #4119
Commit: fcd32ba

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	31.20ms - 33.54ms	-	unsure 🔍 -4% - +4% -1.41ms - +1.34ms	unsure 🔍 -7% - +3% -2.30ms - +1.09ms
tip-of-tree tip-of-tree	31.69ms - 33.13ms	unsure 🔍 -4% - +4% -1.34ms - +1.41ms	-	unsure 🔍 -6% - +3% -2.00ms - +0.85ms
previous-release previous-release	31.75ms - 34.21ms	unsure 🔍 -3% - +7% -1.09ms - +2.30ms	unsure 🔍 -3% - +6% -0.85ms - +2.00ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	85.19ms - 88.99ms	-	unsure 🔍 -2% - +5% -1.72ms - +4.24ms	unsure 🔍 -4% - +2% -3.99ms - +1.58ms
tip-of-tree tip-of-tree	83.53ms - 88.13ms	unsure 🔍 -5% - +2% -4.24ms - +1.72ms	-	unsure 🔍 -6% - +1% -5.54ms - +0.61ms
previous-release previous-release	86.26ms - 90.34ms	unsure 🔍 -2% - +5% -1.58ms - +3.99ms	unsure 🔍 -1% - +7% -0.61ms - +5.54ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	22.37ms - 22.90ms	-	faster ✔ 1% - 9% 0.12ms - 2.22ms	unsure 🔍 -4% - +1% -0.81ms - +0.29ms
tip-of-tree tip-of-tree	22.79ms - 24.82ms	slower ❌ 1% - 10% 0.12ms - 2.22ms	-	unsure 🔍 -1% - +9% -0.21ms - +2.03ms
previous-release previous-release	22.42ms - 23.37ms	unsure 🔍 -1% - +4% -0.29ms - +0.81ms	unsure 🔍 -8% - +1% -2.03ms - +0.21ms	-

lit-html-repeat

Browser: chrome-headless 107.0.5304.121
Sample size: 30
Built by: Benchmarks #4119
Commit: fcd32ba

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.56ms - 12.36ms	-	unsure 🔍 -5% - +4% -0.62ms - +0.48ms	unsure 🔍 -4% - +5% -0.52ms - +0.63ms
tip-of-tree tip-of-tree	11.65ms - 12.41ms	unsure 🔍 -4% - +5% -0.48ms - +0.62ms	-	unsure 🔍 -4% - +6% -0.44ms - +0.68ms
previous-release previous-release	11.49ms - 12.33ms	unsure 🔍 -5% - +4% -0.63ms - +0.52ms	unsure 🔍 -6% - +4% -0.68ms - +0.44ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	315.81ms - 325.96ms	-	unsure 🔍 -0% - +4% -0.17ms - +13.24ms	unsure 🔍 -1% - +3% -3.71ms - +10.49ms
tip-of-tree tip-of-tree	309.97ms - 318.74ms	unsure 🔍 -4% - +0% -13.24ms - +0.17ms	-	unsure 🔍 -3% - +1% -9.77ms - +3.48ms
previous-release previous-release	312.53ms - 322.46ms	unsure 🔍 -3% - +1% -10.49ms - +3.71ms	unsure 🔍 -1% - +3% -3.48ms - +9.77ms	-

lit-html-template-heavy

Browser: chrome-headless 107.0.5304.121
Sample size: 50
Built by: Benchmarks #4119
Commit: fcd32ba

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	55.82ms - 57.49ms	-	unsure 🔍 -3% - +2% -1.44ms - +1.07ms	unsure 🔍 -1% - +3% -0.61ms - +1.44ms
tip-of-tree tip-of-tree	55.91ms - 57.78ms	unsure 🔍 -2% - +3% -1.07ms - +1.44ms	-	unsure 🔍 -1% - +3% -0.51ms - +1.71ms
previous-release previous-release	55.64ms - 56.84ms	unsure 🔍 -3% - +1% -1.44ms - +0.61ms	unsure 🔍 -3% - +1% -1.71ms - +0.51ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	117.49ms - 120.24ms	-	unsure 🔍 -3% - +1% -3.11ms - +1.10ms	unsure 🔍 -1% - +2% -1.47ms - +2.44ms
tip-of-tree tip-of-tree	118.27ms - 121.46ms	unsure 🔍 -1% - +3% -1.10ms - +3.11ms	-	unsure 🔍 -1% - +3% -0.63ms - +3.60ms
previous-release previous-release	116.99ms - 119.76ms	unsure 🔍 -2% - +1% -2.44ms - +1.47ms	unsure 🔍 -3% - +1% -3.60ms - +0.63ms	-

reactive-element-list

Browser: chrome-headless 107.0.5304.121
Sample size: 50
Built by: Benchmarks #4119
Commit: fcd32ba

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	55.57ms - 58.28ms	-	unsure 🔍 -3% - +3% -1.63ms - +1.83ms	unsure 🔍 -1% - +5% -0.57ms - +2.74ms
tip-of-tree tip-of-tree	55.75ms - 57.90ms	unsure 🔍 -3% - +3% -1.83ms - +1.63ms	-	unsure 🔍 -1% - +4% -0.46ms - +2.42ms
previous-release previous-release	54.88ms - 56.80ms	unsure 🔍 -5% - +1% -2.74ms - +0.57ms	unsure 🔍 -4% - +1% -2.42ms - +0.46ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	825.66ms - 837.21ms	-	unsure 🔍 -1% - +1% -5.62ms - +10.68ms	unsure 🔍 -1% - +1% -7.73ms - +8.33ms
tip-of-tree tip-of-tree	823.15ms - 834.65ms	unsure 🔍 -1% - +1% -10.68ms - +5.62ms	-	unsure 🔍 -1% - +1% -10.24ms - +5.78ms
previous-release previous-release	825.56ms - 836.71ms	unsure 🔍 -1% - +1% -8.33ms - +7.73ms	unsure 🔍 -1% - +1% -5.78ms - +10.24ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	840.93ms - 850.76ms	-	unsure 🔍 -1% - +1% -7.47ms - +7.07ms	unsure 🔍 -1% - +0% -11.23ms - +2.52ms
tip-of-tree tip-of-tree	840.69ms - 851.41ms	unsure 🔍 -1% - +1% -7.07ms - +7.47ms	-	unsure 🔍 -1% - +0% -11.36ms - +3.04ms
previous-release previous-release	845.40ms - 855.01ms	unsure 🔍 -0% - +1% -2.52ms - +11.23ms	unsure 🔍 -0% - +1% -3.04ms - +11.36ms	-

_{tachometer-reporter-action v2 for Benchmarks}

kevinpschaaf

LGTM, thanks!

lit init dir -> out, clean up code & -.npmignore

0432b1f

e111077 requested a review from kevinpschaaf November 15, 2022 00:40

e111077 requested a review from justinfagnani as a code owner November 15, 2022 00:40

e111077 mentioned this pull request Nov 15, 2022

Implement lit init element #3248

Merged

kevinpschaaf approved these changes Nov 15, 2022

View reviewed changes

e111077 added 2 commits December 1, 2022 14:46

upload changeset

ad8d506

Merge branch 'main' into lit-init-element-followup

fdb440b

e111077 merged commit cd46b59 into main Dec 1, 2022

e111077 deleted the lit-init-element-followup branch December 1, 2022 23:25

This was referenced Dec 7, 2022

Version Packages #3504

Closed

Version Packages #3506

Merged

Conversation

e111077 commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

kevinpschaaf left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

e111077 commented Nov 15, 2022 •

edited

Loading

changeset-bot bot commented Nov 15, 2022 •

edited

Loading

github-actions bot commented Nov 15, 2022 •

edited

Loading