[labs/testing] testing package with SSR testing utilities by augustjk · Pull Request #2957 · lit/lit

augustjk · 2022-05-26T00:34:47Z

Resolves #2867

This PR adds a @lit-labs/testing package.

The litSsrPlugin plugin for Web Test Runner registers the lit-ssr-render server command that takes the template and module paths, and renders them within a worker thread in the same manner as eleventy-plugin-lit.

The server command is utilized by ssrFixture to be called in the test file supplying lit-html template to render and component definition module path(s).

The README has example usage.

Still to do are to add tests, and a fixture function with client side rendering with the same signature for ease of writing tests across the different rendering methods.

This is still an early draft and I'm looking for feedback on

The structure of the package and exports.
Possibly a better way to handle the relative paths of the modules.
How to test -- I'm currently thinking doing an integration test with a whole sample component, running WTR with Chrome, FF, Safari, with the plugin registered and running tests utilizing all the fixture function. I'm unsure how to unit test this, if necessary.

changeset-bot · 2022-05-26T00:34:50Z

🦋 Changeset detected

Latest commit: cd6144e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-05-26T00:35:31Z

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

nop-update

⏱ lit-html-kitchen-sink: unsure 🔍 -1% - +2% (-0.28ms - +0.55ms)
^{this-change vs tip-of-tree}

render

⏱ lit-element-list: unsure 🔍 -2% - +1% (-1.67ms - +0.80ms)
^{this-change vs tip-of-tree}
⏱ lit-html-kitchen-sink: unsure 🔍 -8% - +4% (-2.63ms - +1.18ms)
^{this-change vs tip-of-tree}
⏱ lit-html-repeat: unsure 🔍 -3% - +2% (-0.33ms - +0.22ms)
^{this-change vs tip-of-tree}
⏱ lit-html-template-heavy: unsure 🔍 -2% - +0% (-0.91ms - +0.10ms)
^{this-change vs tip-of-tree}
⏱ reactive-element-list: unsure 🔍 -11% - +12% (-9.85ms - +10.53ms)
^{this-change vs tip-of-tree}

update

⏱ lit-element-list: unsure 🔍 -7% - +1% (-55.97ms - +7.85ms)
^{this-change vs tip-of-tree}
⏱ lit-html-kitchen-sink: faster ✔ 0% - 5% (0.12ms - 3.81ms)
^{this-change vs tip-of-tree}
⏱ lit-html-repeat: unsure 🔍 -4% - +5% (-14.65ms - +20.21ms)
^{this-change vs tip-of-tree}
⏱ lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.44ms - +1.74ms)
^{this-change vs tip-of-tree}
⏱ reactive-element-list: unsure 🔍 -6% - +16% (-48.75ms - +141.17ms)
^{this-change vs tip-of-tree}

update-reflect

⏱ lit-element-list: unsure 🔍 -1% - +0% (-8.17ms - +1.84ms)
^{this-change vs tip-of-tree}
⏱ reactive-element-list: unsure 🔍 -2% - +1% (-19.13ms - +12.91ms)
^{this-change vs tip-of-tree}

Results

⏳ Benchmarks are currently running. Results below are out of date.

⏱ lit-element-list

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #3474
Commit: 6af5d99

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	76.54ms - 78.10ms	-	unsure 🔍 -2% - +1% -1.67ms - +0.80ms	faster ✔ 18% - 20% 16.86ms - 18.84ms
tip-of-tree tip-of-tree	76.80ms - 78.72ms	unsure 🔍 -1% - +2% -0.80ms - +1.67ms	-	faster ✔ 17% - 19% 16.28ms - 18.56ms
previous-release previous-release	94.56ms - 95.79ms	slower ❌ 22% - 25% 16.86ms - 18.84ms	slower ❌ 21% - 24% 16.28ms - 18.56ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	797.87ms - 825.95ms	-	unsure 🔍 -7% - +1% -55.97ms - +7.85ms	faster ✔ 34% - 37% 426.23ms - 461.43ms
tip-of-tree tip-of-tree	807.31ms - 864.63ms	unsure 🔍 -1% - +7% -7.85ms - +55.97ms	-	faster ✔ 31% - 36% 389.21ms - 450.33ms
previous-release previous-release	1245.13ms - 1266.35ms	slower ❌ 52% - 58% 426.23ms - 461.43ms	slower ❌ 45% - 56% 389.21ms - 450.33ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	808.88ms - 814.40ms	-	unsure 🔍 -1% - +0% -8.17ms - +1.84ms	faster ✔ 8% - 9% 71.31ms - 82.97ms
tip-of-tree tip-of-tree	810.62ms - 818.98ms	unsure 🔍 -0% - +1% -1.84ms - +8.17ms	-	faster ✔ 8% - 9% 67.36ms - 80.60ms
previous-release previous-release	883.64ms - 893.91ms	slower ❌ 9% - 10% 71.31ms - 82.97ms	slower ❌ 8% - 10% 67.36ms - 80.60ms	-

⏱ lit-html-kitchen-sink

Browser: chrome-headless 102.0.5005.115
Sample size: 30
Built by: Benchmarks #3474
Commit: 6af5d99

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	30.16ms - 30.56ms	-	unsure 🔍 -8% - +4% -2.63ms - +1.18ms	faster ✔ 12% - 15% 4.03ms - 5.32ms
tip-of-tree tip-of-tree	29.19ms - 32.98ms	unsure 🔍 -4% - +9% -1.18ms - +2.63ms	-	faster ✔ 6% - 17% 1.96ms - 5.94ms
previous-release previous-release	34.42ms - 35.65ms	slower ❌ 13% - 18% 4.03ms - 5.32ms	slower ❌ 6% - 20% 1.96ms - 5.94ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	80.03ms - 82.22ms	-	faster ✔ 0% - 5% 0.12ms - 3.81ms	faster ✔ 3% - 8% 2.51ms - 7.21ms
tip-of-tree tip-of-tree	81.61ms - 84.58ms	slower ❌ 0% - 5% 0.12ms - 3.81ms	-	faster ✔ 0% - 6% 0.34ms - 5.45ms
previous-release previous-release	83.90ms - 88.07ms	slower ❌ 3% - 9% 2.51ms - 7.21ms	slower ❌ 0% - 7% 0.34ms - 5.45ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	25.74ms - 26.32ms	-	unsure 🔍 -1% - +2% -0.28ms - +0.55ms	faster ✔ 10% - 17% 3.00ms - 5.30ms
tip-of-tree tip-of-tree	25.60ms - 26.19ms	unsure 🔍 -2% - +1% -0.55ms - +0.28ms	-	faster ✔ 11% - 18% 3.13ms - 5.43ms
previous-release previous-release	29.06ms - 31.29ms	slower ❌ 11% - 20% 3.00ms - 5.30ms	slower ❌ 12% - 21% 3.13ms - 5.43ms	-

⏱ lit-html-repeat

Browser: chrome-headless 102.0.5005.115
Sample size: 30
Built by: Benchmarks #3474
Commit: 6af5d99

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.83ms - 11.25ms	-	unsure 🔍 -3% - +2% -0.33ms - +0.22ms	faster ✔ 7% - 11% 0.88ms - 1.34ms
tip-of-tree tip-of-tree	10.92ms - 11.27ms	unsure 🔍 -2% - +3% -0.22ms - +0.33ms	-	faster ✔ 7% - 10% 0.86ms - 1.26ms
previous-release previous-release	12.06ms - 12.24ms	slower ❌ 8% - 12% 0.88ms - 1.34ms	slower ❌ 8% - 11% 0.86ms - 1.26ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	383.74ms - 416.14ms	-	unsure 🔍 -4% - +5% -14.65ms - +20.21ms	faster ✔ 19% - 28% 98.87ms - 148.60ms
tip-of-tree tip-of-tree	390.72ms - 403.60ms	unsure 🔍 -5% - +4% -20.21ms - +14.65ms	-	faster ✔ 21% - 27% 106.58ms - 146.45ms
previous-release previous-release	504.81ms - 542.54ms	slower ❌ 24% - 38% 98.87ms - 148.60ms	slower ❌ 27% - 37% 106.58ms - 146.45ms	-

⏱ lit-html-template-heavy

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #3474
Commit: 6af5d99

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	54.44ms - 55.15ms	-	unsure 🔍 -2% - +0% -0.91ms - +0.10ms	faster ✔ 16% - 18% 10.33ms - 12.05ms
tip-of-tree tip-of-tree	54.85ms - 55.56ms	unsure 🔍 -0% - +2% -0.10ms - +0.91ms	-	faster ✔ 15% - 17% 9.93ms - 11.64ms
previous-release previous-release	65.21ms - 66.77ms	slower ❌ 19% - 22% 10.33ms - 12.05ms	slower ❌ 18% - 21% 9.93ms - 11.64ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	125.10ms - 127.44ms	-	unsure 🔍 -1% - +1% -1.44ms - +1.74ms	faster ✔ 13% - 15% 18.26ms - 21.57ms
tip-of-tree tip-of-tree	125.05ms - 127.20ms	unsure 🔍 -1% - +1% -1.74ms - +1.44ms	-	faster ✔ 13% - 15% 18.47ms - 21.65ms
previous-release previous-release	145.02ms - 147.36ms	slower ❌ 14% - 17% 18.26ms - 21.57ms	slower ❌ 15% - 17% 18.47ms - 21.65ms	-

⏱ reactive-element-list

Browser: chrome-headless 102.0.5005.115
Sample size: 50
Built by: Benchmarks #3474
Commit: 6af5d99

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	79.61ms - 93.79ms	-	unsure 🔍 -11% - +12% -9.85ms - +10.53ms	unsure 🔍 -12% - +11% -10.47ms - +9.81ms
tip-of-tree tip-of-tree	79.05ms - 93.68ms	unsure 🔍 -12% - +11% -10.53ms - +9.85ms	-	unsure 🔍 -13% - +11% -10.97ms - +9.63ms
previous-release previous-release	79.78ms - 94.28ms	unsure 🔍 -11% - +12% -9.81ms - +10.47ms	unsure 🔍 -11% - +13% -9.63ms - +10.97ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	884.36ms - 1031.81ms	-	unsure 🔍 -6% - +16% -48.75ms - +141.17ms	unsure 🔍 -2% - +19% -12.78ms - +162.16ms
tip-of-tree tip-of-tree	852.03ms - 971.72ms	unsure 🔍 -14% - +5% -141.17ms - +48.75ms	-	unsure 🔍 -6% - +12% -47.65ms - +104.61ms
previous-release previous-release	836.33ms - 930.46ms	unsure 🔍 -16% - +1% -162.16ms - +12.78ms	unsure 🔍 -11% - +5% -104.61ms - +47.65ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	879.35ms - 901.54ms	-	unsure 🔍 -2% - +1% -19.13ms - +12.91ms	unsure 🔍 -2% - +2% -15.76ms - +16.75ms
tip-of-tree tip-of-tree	881.99ms - 905.11ms	unsure 🔍 -1% - +2% -12.91ms - +19.13ms	-	unsure 🔍 -1% - +2% -12.97ms - +20.18ms
previous-release previous-release	878.07ms - 901.83ms	unsure 🔍 -2% - +2% -16.75ms - +15.76ms	unsure 🔍 -2% - +1% -20.18ms - +12.97ms	-

_{tachometer-reporter-action v2 for Benchmarks}

packages/labs/testing/src/web-test-runner/worker/worker.ts

packages/labs/testing/README.md

kevinpschaaf · 2022-05-26T16:10:01Z

Possibly a better way to handle the relative paths of the modules.

It seems like we'll need to require the fixture caller to pass their import.meta.url in order to allow them to use relative paths, something like:

    const el = await ssrFixture(html`<my-element></my-element>`, {
      base: import.meta.url, // path to resolve relative modules against
      modules: ['./my-element.js'], // path to component definition, relative to base (or cwd if not specified)
      hydrate: false, // whether to hydrate the component after loading to document (default: true)
    });

On the client, it would just import(new URL(module[i], base).href), and on the server it should be able to work out where to import it from relative to where the server is serving from?

kevinpschaaf · 2022-05-26T16:29:37Z

How to test -- I'm currently thinking doing an integration test with a whole sample component, running WTR with Chrome, FF, Safari, with the plugin registered and running tests utilizing all the fixture function. I'm unsure how to unit test this, if necessary

Yeah, doing this as an integration test seems like the most bang-for-buck. Seems like you'll want to test a variety of component scenarios, obv a happy case where it all passes, but also some cases where we expect the tests to fail e.g. to ensure we catch when users do SSR-incompatible things. I'd expect main focus to be on the latter, since the labs/ssr integration tests themselves focus on all the happy cases.

^^ points out that we'll want to nicely pipe errors raised from render-lit-html:render() on the server back through to the client via a rejection on the async fixture; that should allow writing try/catch blocks in the integration test to ensure they fail when expected.

(hmmm, now that I think about it)

I'd expect main focus to be on the latter, since the SSR tests themselves focus on all the happy cases.

Seems like we might just be able to switch all the labs/ssr integration tests to use this and use a normal WTR setup; it would just require all the element definitions in the LitElement tests to be moved out to their own modules. But that can happen separately after we get some basic tests for this landed.

aomarks

This is looking really great! Pretty minor comments.

packages/labs/testing/README.md

packages/labs/testing/src/lib/fixtures/ssrFixture.ts

packages/labs/testing/src/lib/litSsrPlugin.ts

packages/labs/testing/src/lib/worker.ts

aomarks

Looks great! Just some minor comments, LGTM otherwise.

packages/labs/testing/README.md

aomarks · 2022-06-22T21:53:04Z

packages/labs/testing/src/lib/fixtures/ssr-fixture.ts

+    }
+  );
+
+  // TODO(augustinekim) Clean up the container from the document


How will we know when to do the cleanup? I wonder if we should have a cleanupFixtures or something, which tracks all fixtures in a global, that users can put in their after callbacks?

open-wc's implementation keeps the containers in a module scoped array https://github.com/open-wc/open-wc/blob/master/packages/testing-helpers/src/fixtureWrapper.js and the fixture import has a side effect of registering the cleanup on afterEach and teardown if mocha is registered globally. https://github.com/open-wc/open-wc/blob/master/packages/testing-helpers/src/fixture.js

We could also provide the cleanup function for users to call themselves if they care about cleaning up.

+1 to a cleanupFixtures function, that makes sense.

We could also just have fixture keep a module-scoped lastContainer and remove it before creating another so we're not accumulating loads of containers during a long suite, if it's safe to assume people don't generally create multiple fixtures in tests (?, not sure about that).

Added a cleanupFixtures for now.

I haven't seen cases of users creating multiple fixtures in a single test but don't want to discount that it might happen. I don't feel like trying to automatically clean up is important enough to potentially break that particular use case.

packages/labs/testing/src/lib/fixtures/ssr-fixture.ts

Co-authored-by: Alexander Marks <aomarks@google.com>

kevinpschaaf

Just a few minor suggestions and clarifications; feel free to consider/resolve, but I'm good merging this based on your judgement on those.

kevinpschaaf · 2022-06-24T10:49:58Z

packages/labs/testing/src/lib/fixtures/ssr-fixture.ts

+    }
+  );
+
+  // TODO(augustinekim) Clean up the container from the document


+1 to a cleanupFixtures function, that makes sense.

We could also just have fixture keep a module-scoped lastContainer and remove it before creating another so we're not accumulating loads of containers during a long suite, if it's safe to assume people don't generally create multiple fixtures in tests (?, not sure about that).

kevinpschaaf · 2022-06-24T11:08:24Z

packages/labs/testing/src/lib/fixtures/csr-fixture.ts

+      /http:\/\/localhost.+(?=\?wtr-session-id)/
+    );
+    if (!match) {
+      throw new Error('Could not find call site for csrFixture');


In what cases do we expect this to fail? It's unclear in the readme if users are expected to pass import.meta.url or if they can reasonably expect this to work without having to pass that. Maybe clarify?

I don't anticipate us to ever reach this unless how the stack is generated gets changed (or the regex somehow fails for some browser besides chrome, firefox, webkit) or if web test runner changes the query to something other than wtr-session-id.

I've updated the readme to expand more on the base option. Leaving it empty should have the same behavior as passing in import.meta.url.

kevinpschaaf · 2022-06-24T11:09:53Z

packages/labs/testing/src/lib/fixtures/csr-fixture.ts

+  render(template, container);
+
+  // Awaiting for the next microtask to ensure contents are rendered.
+  await undefined;


Not sure what the open-wc fixture does, but it might be good to wait a requestAnimationFrame instead, to ensure the entire tree of components (if there are multiple levels) are done rendering...?

https://github.com/open-wc/open-wc/blob/master/packages/testing-helpers/src/elementUpdated.js

open-wc looks for specific promises to await on and falls back to requestAnimationFrame if they don't exist. Perhaps we could do something similar and look for updateComplete and await that.

kevinpschaaf · 2022-06-24T11:18:57Z

packages/labs/testing/src/lib/worker.ts

+(strings as {raw: TemplateStringsArray['raw']}).raw = strings;
+
+let rendered = '';
+for (const str of render({...template, strings}, {deferHydration: true})) {


Not familiar with how workers work... since this is all executed in module scope, if it throws, then we'll get a worker.on('error') callback?

Yes that's correct. Currently the wtr server command simply fails for those cases so the fixture function call will then throw. We see that happen in the bad-element test.

kevinpschaaf · 2022-06-24T11:20:31Z

packages/labs/testing/src/lib/lit-ssr-plugin.ts

+export function litSsrPlugin(): TestRunnerPlugin<Payload> {
+  return {
+    name: 'lit-ssr-plugin',
+    async executeCommand({command, payload}) {


Not blocking for this PR, but would love to think about how this could be factored a little differently so that it could be called from e.g. a koa/express middleware as well, so we're not tied directly to web-test-runner. Should be straightforward, I think?

packages/labs/testing/src/lib/utils.ts

packages/labs/testing/README.md

aomarks

LGTM pending 3 comments!

augustjk requested review from aomarks, justinfagnani and kevinpschaaf May 26, 2022 00:34

kevinpschaaf reviewed May 26, 2022

View reviewed changes

packages/labs/testing/src/web-test-runner/worker/worker.ts Outdated Show resolved Hide resolved

packages/labs/testing/README.md Outdated Show resolved Hide resolved

augustjk force-pushed the testing-util branch 2 times, most recently from c3cecdf to 5466d84 Compare May 31, 2022 17:12

augustjk mentioned this pull request Jun 3, 2022

Server-side rendering (SSR) compatibility shoelace-style/shoelace#778

Closed

augustjk force-pushed the testing-util branch 3 times, most recently from 38c3813 to cc44c30 Compare June 8, 2022 17:43

augustjk marked this pull request as ready for review June 8, 2022 18:23

aomarks requested changes Jun 8, 2022

View reviewed changes

augustjk force-pushed the testing-util branch from 434e518 to 031db9c Compare June 13, 2022 19:21

augustjk added 13 commits June 16, 2022 17:06

Initial testing package

ee530bd

Add empty changeset

39d1b99

Fix date on license file

d85acd1

Add csrFixture and take module paths relative to test file

84f7b51

Simplify worker code and reorganize files

055d643

Reorganize exports

58a65dc

Add good element tests

f475387

Add files and output to test wireit

0b1d9aa

Use stack trace to determine base url for modules

f4885af

Make base path optional and fallback to stacktrace

c4663fc

Fix packaged files

3214ad5

Add type arg to fixture functions

3c117a8

Sync ignore files

17ec511

augustjk added 4 commits June 16, 2022 17:06

Refactor plugin to early return on wrong command

f988001

Fix plugin import for wtr

30ae6dc

Sync ignore files

a18bf0f

Handle non lit elements as top level in fixtures

91f1254

augustjk force-pushed the testing-util branch from 031db9c to 91f1254 Compare June 17, 2022 00:23

augustjk requested a review from aomarks June 17, 2022 00:31

aomarks approved these changes Jun 22, 2022

View reviewed changes

augustjk and others added 2 commits June 22, 2022 15:29

Apply suggestions from code review

a344f93

Co-authored-by: Alexander Marks <aomarks@google.com>

Wrap rendered content in body tag for DOM Parser

66ea323

augustjk requested a review from kevinpschaaf June 23, 2022 21:53

kevinpschaaf approved these changes Jun 24, 2022

View reviewed changes

augustjk added 6 commits June 27, 2022 17:12

Await on updateComplete or next animation frame

8b64cca

Reorg exports and add strip comment helpers

cc7b3dd

Fix package.json, tsconfig, and ignorefiles

13e5803

Add testing package to workspace

d465eda

Add function to clean up fixtures from document

a6851e9

Add changeset for initial release

cd683d4

aomarks reviewed Jun 28, 2022

View reviewed changes

packages/labs/testing/src/lib/utils.ts Show resolved Hide resolved

aomarks reviewed Jun 28, 2022

View reviewed changes

packages/labs/testing/src/lib/utils.ts Show resolved Hide resolved

aomarks reviewed Jun 28, 2022

View reviewed changes

packages/labs/testing/README.md Outdated Show resolved Hide resolved

aomarks approved these changes Jun 28, 2022

View reviewed changes

augustjk added 3 commits June 28, 2022 16:43

Rename to web-test-runner-ssr-plugin

16bad9c

Fix test to use type argument

92eec24

Update readme to add fixture function signature

cd6144e

augustjk merged commit a2491c3 into main Jun 29, 2022

augustjk deleted the testing-util branch June 29, 2022 01:05

This was referenced Jun 29, 2022

Version Packages #3070

Closed

Version Packages #3106

Merged

augustjk mentioned this pull request Jul 15, 2022

[ssr] Make test utility for testing components in SSR #2351

Closed

snyk-bot mentioned this pull request Aug 28, 2022

[Snyk] Upgrade lit from 2.2.4 to 2.2.8 violethaze74/lit#5

Open

Conversation

augustjk commented May 26, 2022

Uh oh!

changeset-bot bot commented May 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented May 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Uh oh!

Uh oh!

kevinpschaaf commented May 26, 2022

Uh oh!

kevinpschaaf commented May 26, 2022

Uh oh!

aomarks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aomarks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kevinpschaaf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

changeset-bot bot commented May 26, 2022 •

edited

Loading

github-actions bot commented May 26, 2022 •

edited

Loading

aomarks left a comment •

edited

Loading