[starter-kits] Update starter kit dependencies by augustjk · Pull Request #2922 · lit/lit

augustjk · 2022-05-18T01:41:35Z

Many dependencies in the starter kits were out of date and had vulnerabilities.

This update takes us from

34 vulnerabilities (10 moderate, 23 high, 1 critical)

to

3 high severity vulnerabilities

The remaining vulnerabilities requires bumping dependency in lit-analyzer which I've decided to punt.

There were also several unused dependencies that I've removed from the starter kit repos:

@esm-bundle/chai
@open-wc/testing-karma
@types/mocha
@web/dev-server-rollup
@web/test-runner-mocha
deepmerge
mocha

Also removed my-element.bundled.js from git history. It was already gitignored in the js starter. Added it to ts starter as well.

Confirmed npm scripts in the repos still work.

changeset-bot · 2022-05-18T01:41:37Z

🦋 Changeset detected

Latest commit: 1ec9e21

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-05-18T01:41:55Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -3% - +3% (-0.98ms - +0.95ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -2% - +1% (-2.05ms - +0.50ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -2% - +4% (-0.53ms - +1.36ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +3% (-0.19ms - +0.39ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.91ms - +1.06ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -18% - +9% (-15.53ms - +7.41ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -2% - +4% (-14.30ms - +35.00ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-2.20ms - +3.21ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -7% - +7% (-27.72ms - +27.82ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +3% (-1.01ms - +3.59ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -20% - +4% (-262.63ms - +51.21ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +2% (-13.53ms - +19.20ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +1% (-23.19ms - +12.99ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 101.0.4951.54
Sample size: 50
Built by: Benchmarks #3134
Commit: ecad354

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	86.48ms - 88.34ms	-	unsure 🔍 -2% - +1% -2.05ms - +0.50ms	faster ✔ 18% - 20% 19.11ms - 22.21ms
tip-of-tree tip-of-tree	87.32ms - 89.05ms	unsure 🔍 -1% - +2% -0.50ms - +2.05ms	-	faster ✔ 17% - 20% 18.38ms - 21.40ms
previous-release previous-release	106.84ms - 109.31ms	slower ❌ 22% - 26% 19.11ms - 22.21ms	slower ❌ 21% - 24% 18.38ms - 21.40ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	910.95ms - 953.91ms	-	unsure 🔍 -2% - +4% -14.30ms - +35.00ms	faster ✔ 34% - 37% 489.26ms - 545.79ms
tip-of-tree tip-of-tree	909.99ms - 934.16ms	unsure 🔍 -4% - +2% -35.00ms - +14.30ms	-	faster ✔ 35% - 38% 505.89ms - 549.87ms
previous-release previous-release	1431.59ms - 1468.32ms	slower ❌ 51% - 60% 489.26ms - 545.79ms	slower ❌ 54% - 60% 505.89ms - 549.87ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	895.42ms - 919.13ms	-	unsure 🔍 -1% - +2% -13.53ms - +19.20ms	faster ✔ 7% - 10% 63.49ms - 98.32ms
tip-of-tree tip-of-tree	893.16ms - 915.71ms	unsure 🔍 -2% - +1% -19.20ms - +13.53ms	-	faster ✔ 7% - 10% 66.71ms - 100.76ms
previous-release previous-release	975.42ms - 1000.93ms	slower ❌ 7% - 11% 63.49ms - 98.32ms	slower ❌ 7% - 11% 66.71ms - 100.76ms	-

lit-html-kitchen-sink

Browser: chrome-headless 101.0.4951.54
Sample size: 30
Built by: Benchmarks #3134
Commit: ecad354

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.29ms - 36.00ms	-	unsure 🔍 -2% - +4% -0.53ms - +1.36ms	faster ✔ 10% - 17% 3.72ms - 7.20ms
tip-of-tree tip-of-tree	34.33ms - 35.13ms	unsure 🔍 -4% - +1% -1.36ms - +0.53ms	-	faster ✔ 11% - 18% 4.31ms - 7.44ms
previous-release previous-release	39.09ms - 42.12ms	slower ❌ 10% - 21% 3.72ms - 7.20ms	slower ❌ 12% - 21% 4.31ms - 7.44ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	91.45ms - 95.84ms	-	unsure 🔍 -2% - +3% -2.20ms - +3.21ms	unsure 🔍 -5% - +1% -4.91ms - +1.41ms
tip-of-tree tip-of-tree	91.56ms - 94.72ms	unsure 🔍 -3% - +2% -3.21ms - +2.20ms	-	unsure 🔍 -5% - +0% -5.03ms - +0.51ms
previous-release previous-release	93.12ms - 97.67ms	unsure 🔍 -2% - +5% -1.41ms - +4.91ms	unsure 🔍 -1% - +5% -0.51ms - +5.03ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.70ms - 31.40ms	-	unsure 🔍 -3% - +3% -0.98ms - +0.95ms	faster ✔ 7% - 14% 2.46ms - 4.67ms
tip-of-tree tip-of-tree	30.11ms - 31.03ms	unsure 🔍 -3% - +3% -0.95ms - +0.98ms	-	faster ✔ 8% - 13% 2.70ms - 4.40ms
previous-release previous-release	33.41ms - 34.83ms	slower ❌ 8% - 16% 2.46ms - 4.67ms	slower ❌ 9% - 14% 2.70ms - 4.40ms	-

lit-html-repeat

Browser: chrome-headless 101.0.4951.54
Sample size: 30
Built by: Benchmarks #3134
Commit: ecad354

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	12.93ms - 13.38ms	-	unsure 🔍 -1% - +3% -0.19ms - +0.39ms	faster ✔ 8% - 11% 1.12ms - 1.60ms
tip-of-tree tip-of-tree	12.87ms - 13.23ms	unsure 🔍 -3% - +1% -0.39ms - +0.19ms	-	faster ✔ 9% - 11% 1.27ms - 1.66ms
previous-release previous-release	14.44ms - 14.59ms	slower ❌ 8% - 12% 1.12ms - 1.60ms	slower ❌ 10% - 13% 1.27ms - 1.66ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	399.58ms - 438.82ms	-	unsure 🔍 -7% - +7% -27.72ms - +27.82ms	faster ✔ 19% - 28% 102.43ms - 156.96ms
tip-of-tree tip-of-tree	399.50ms - 438.81ms	unsure 🔍 -7% - +7% -27.82ms - +27.72ms	-	faster ✔ 19% - 28% 102.45ms - 157.03ms
previous-release previous-release	529.96ms - 567.83ms	slower ❌ 23% - 39% 102.43ms - 156.96ms	slower ❌ 23% - 39% 102.45ms - 157.03ms	-

lit-html-template-heavy

Browser: chrome-headless 101.0.4951.54
Sample size: 50
Built by: Benchmarks #3134
Commit: ecad354

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	63.40ms - 64.93ms	-	unsure 🔍 -1% - +2% -0.91ms - +1.06ms	faster ✔ 14% - 17% 10.36ms - 12.61ms
tip-of-tree tip-of-tree	63.46ms - 64.70ms	unsure 🔍 -2% - +1% -1.06ms - +0.91ms	-	faster ✔ 14% - 17% 10.53ms - 12.59ms
previous-release previous-release	74.82ms - 76.47ms	slower ❌ 16% - 20% 10.36ms - 12.61ms	slower ❌ 16% - 20% 10.53ms - 12.59ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	139.59ms - 143.14ms	-	unsure 🔍 -1% - +3% -1.01ms - +3.59ms	faster ✔ 12% - 15% 19.60ms - 24.66ms
tip-of-tree tip-of-tree	138.62ms - 141.53ms	unsure 🔍 -3% - +1% -3.59ms - +1.01ms	-	faster ✔ 13% - 16% 21.11ms - 25.74ms
previous-release previous-release	161.69ms - 165.30ms	slower ❌ 14% - 18% 19.60ms - 24.66ms	slower ❌ 15% - 18% 21.11ms - 25.74ms	-

reactive-element-list

Browser: chrome-headless 101.0.4951.54
Sample size: 50
Built by: Benchmarks #3134
Commit: ecad354

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	70.60ms - 86.35ms	-	unsure 🔍 -18% - +9% -15.53ms - +7.41ms	unsure 🔍 -24% - +1% -21.60ms - +1.84ms
tip-of-tree tip-of-tree	74.19ms - 90.87ms	unsure 🔍 -10% - +20% -7.41ms - +15.53ms	-	unsure 🔍 -20% - +7% -17.86ms - +6.22ms
previous-release previous-release	79.67ms - 97.03ms	unsure 🔍 -3% - +28% -1.84ms - +21.60ms	unsure 🔍 -8% - +22% -6.22ms - +17.86ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1043.61ms - 1258.08ms	-	unsure 🔍 -20% - +4% -262.63ms - +51.21ms	unsure 🔍 -14% - +12% -160.38ms - +138.22ms
tip-of-tree tip-of-tree	1141.99ms - 1371.12ms	unsure 🔍 -5% - +23% -51.21ms - +262.63ms	-	unsure 🔍 -6% - +22% -60.03ms - +249.27ms
previous-release previous-release	1058.05ms - 1265.81ms	unsure 🔍 -12% - +14% -138.22ms - +160.38ms	unsure 🔍 -19% - +4% -249.27ms - +60.03ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	917.67ms - 946.96ms	-	unsure 🔍 -2% - +1% -23.19ms - +12.99ms	unsure 🔍 -2% - +3% -14.17ms - +24.25ms
tip-of-tree tip-of-tree	926.80ms - 948.04ms	unsure 🔍 -1% - +2% -12.99ms - +23.19ms	-	unsure 🔍 -1% - +3% -6.20ms - +26.48ms
previous-release previous-release	914.85ms - 939.70ms	unsure 🔍 -3% - +2% -24.25ms - +14.17ms	unsure 🔍 -3% - +1% -26.48ms - +6.20ms	-

_{tachometer-reporter-action v2 for Benchmarks}

packages/lit-starter-ts/package.json

packages/lit-starter-js/package.json

augustjk added 9 commits May 17, 2022 17:52

Remove my-element.bundled.js

a1cbe77

Remove unused deps and update rest

7a4090d

Remove deps and update rest for ts

019eae8

Remove my-element.bundled.js in ts

e9f70db

Update ignore files

3030a63

Fix doc index typo

ca31a1d

Update lit for ts

ae94a69

Add changeset

3cf0d78

Update readme to remove ref to mocha and chai

d235d76

augustjk requested a review from justinfagnani as a code owner May 18, 2022 01:41

augustjk changed the title ~~[starter-kits] Update starter kits~~ [starter-kits] Update starter kit dependencies May 18, 2022

justinfagnani reviewed May 18, 2022

View reviewed changes

packages/lit-starter-ts/package.json Outdated Show resolved Hide resolved

packages/lit-starter-js/package.json Show resolved Hide resolved

Fix typescript to minor version

1ec9e21

justinfagnani approved these changes May 18, 2022

View reviewed changes

augustjk merged commit da9db86 into main May 18, 2022

augustjk deleted the update-starterkits branch May 18, 2022 23:42

lit-robot mentioned this pull request May 25, 2022

Version Packages #2954

Merged

Conversation

augustjk commented May 18, 2022

Uh oh!

changeset-bot bot commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented May 18, 2022 •

edited

Loading

github-actions bot commented May 18, 2022 •

edited

Loading