[lit-next] Rename hydrate & hydrate-support to "experimental" by kevinpschaaf · Pull Request #1743 · lit/lit

kevinpschaaf · 2021-04-14T05:14:38Z

We could also consider adding a top-level console.warn in hydrate.js (since hydrate-support also imports it) to the nature of:

Lit hydration support is experimental. Experimental modules may undergo breaking changes within otherwise non-major releases.

WDYT?

github-actions · 2021-04-14T05:15:02Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -5% - +1% (-1.63ms - +0.47ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -2% - +3% (-2.36ms - +3.04ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -3% - +1% (-1.39ms - +0.46ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -5% - +4% (-0.70ms - +0.61ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +3% (-0.91ms - +1.77ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +2% (-1.14ms - +1.42ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -1% - +2% (-5.70ms - +14.63ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -2% - +4% (-2.20ms - +4.85ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +2% (-4.85ms - +9.14ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +1% (-4.79ms - +1.43ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-8.91ms - +11.29ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +1% (-11.74ms - +11.63ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +2% (-5.32ms - +14.79ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 89.0.4389.114
Sample size: 50
Built by: Benchmarks #1262
Commit: b62cd90

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	98.29ms - 102.40ms	-	unsure 🔍 -2% - +3% -2.36ms - +3.04ms	faster ✔ 18% - 22% 22.08ms - 27.15ms
tip-of-tree tip-of-tree	98.26ms - 101.76ms	unsure 🔍 -3% - +2% -3.04ms - +2.36ms	-	faster ✔ 18% - 22% 22.67ms - 27.25ms
previous-release previous-release	123.48ms - 126.45ms	slower ❌ 22% - 27% 22.08ms - 27.15ms	slower ❌ 22% - 28% 22.67ms - 27.25ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	851.84ms - 865.00ms	-	unsure 🔍 -1% - +2% -5.70ms - +14.63ms	faster ✔ 7% - 9% 64.96ms - 85.43ms
tip-of-tree tip-of-tree	846.21ms - 861.71ms	unsure 🔍 -2% - +1% -14.63ms - +5.70ms	-	faster ✔ 7% - 10% 68.64ms - 90.68ms
previous-release previous-release	925.78ms - 941.45ms	slower ❌ 8% - 10% 64.96ms - 85.43ms	slower ❌ 8% - 11% 68.64ms - 90.68ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	918.90ms - 935.13ms	-	unsure 🔍 -1% - +1% -11.74ms - +11.63ms	faster ✔ 3% - 6% 31.50ms - 55.51ms
tip-of-tree tip-of-tree	918.66ms - 935.47ms	unsure 🔍 -1% - +1% -11.63ms - +11.74ms	-	faster ✔ 3% - 6% 31.25ms - 55.66ms
previous-release previous-release	961.68ms - 979.37ms	slower ❌ 3% - 6% 31.50ms - 55.51ms	slower ❌ 3% - 6% 31.25ms - 55.66ms	-

lit-html-kitchen-sink

Browser: chrome-headless 89.0.4389.114
Sample size: 30
Built by: Benchmarks #1262
Commit: b62cd90

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	40.28ms - 41.89ms	-	unsure 🔍 -3% - +1% -1.39ms - +0.46ms	faster ✔ 15% - 21% 7.27ms - 10.88ms
tip-of-tree tip-of-tree	41.09ms - 42.01ms	unsure 🔍 -1% - +3% -0.46ms - +1.39ms	-	faster ✔ 14% - 20% 6.93ms - 10.29ms
previous-release previous-release	48.54ms - 51.78ms	slower ❌ 17% - 27% 7.27ms - 10.88ms	slower ❌ 17% - 25% 6.93ms - 10.29ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	106.49ms - 112.57ms	-	unsure 🔍 -2% - +4% -2.20ms - +4.85ms	unsure 🔍 -1% - +6% -0.92ms - +6.69ms
tip-of-tree tip-of-tree	106.43ms - 109.98ms	unsure 🔍 -4% - +2% -4.85ms - +2.20ms	-	unsure 🔍 -1% - +4% -1.33ms - +4.46ms
previous-release previous-release	104.36ms - 108.92ms	unsure 🔍 -6% - +1% -6.69ms - +0.92ms	unsure 🔍 -4% - +1% -4.46ms - +1.33ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.72ms - 36.09ms	-	unsure 🔍 -5% - +1% -1.63ms - +0.47ms	unsure 🔍 -4% - +2% -1.38ms - +0.68ms
tip-of-tree tip-of-tree	35.19ms - 36.78ms	unsure 🔍 -1% - +5% -0.47ms - +1.63ms	-	unsure 🔍 -2% - +4% -0.88ms - +1.34ms
previous-release previous-release	34.98ms - 36.53ms	unsure 🔍 -2% - +4% -0.68ms - +1.38ms	unsure 🔍 -4% - +2% -1.34ms - +0.88ms	-

lit-html-repeat

Browser: chrome-headless 89.0.4389.114
Sample size: 30
Built by: Benchmarks #1262
Commit: b62cd90

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.27ms - 14.20ms	-	unsure 🔍 -5% - +4% -0.70ms - +0.61ms	faster ✔ 9% - 16% 1.31ms - 2.48ms
tip-of-tree tip-of-tree	13.32ms - 14.24ms	unsure 🔍 -4% - +5% -0.61ms - +0.70ms	-	faster ✔ 8% - 15% 1.27ms - 2.43ms
previous-release previous-release	15.27ms - 15.99ms	slower ❌ 9% - 18% 1.31ms - 2.48ms	slower ❌ 9% - 18% 1.27ms - 2.43ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	407.07ms - 416.70ms	-	unsure 🔍 -1% - +2% -4.85ms - +9.14ms	faster ✔ 27% - 29% 151.08ms - 167.45ms
tip-of-tree tip-of-tree	404.66ms - 414.82ms	unsure 🔍 -2% - +1% -9.14ms - +4.85ms	-	faster ✔ 27% - 29% 153.06ms - 169.76ms
previous-release previous-release	564.52ms - 577.77ms	slower ❌ 36% - 41% 151.08ms - 167.45ms	slower ❌ 37% - 42% 153.06ms - 169.76ms	-

lit-html-template-heavy

Browser: chrome-headless 89.0.4389.114
Sample size: 50
Built by: Benchmarks #1262
Commit: b62cd90

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	65.66ms - 67.65ms	-	unsure 🔍 -1% - +3% -0.91ms - +1.77ms	faster ✔ 20% - 23% 16.41ms - 19.48ms
tip-of-tree tip-of-tree	65.33ms - 67.13ms	unsure 🔍 -3% - +1% -1.77ms - +0.91ms	-	faster ✔ 20% - 23% 16.90ms - 19.85ms
previous-release previous-release	83.43ms - 85.78ms	slower ❌ 24% - 30% 16.41ms - 19.48ms	slower ❌ 25% - 30% 16.90ms - 19.85ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	135.58ms - 139.21ms	-	unsure 🔍 -3% - +1% -4.79ms - +1.43ms	faster ✔ 17% - 20% 27.77ms - 33.05ms
tip-of-tree tip-of-tree	136.55ms - 141.60ms	unsure 🔍 -1% - +3% -1.43ms - +4.79ms	-	faster ✔ 15% - 19% 25.56ms - 31.90ms
previous-release previous-release	165.89ms - 169.72ms	slower ❌ 20% - 24% 27.77ms - 33.05ms	slower ❌ 18% - 23% 25.56ms - 31.90ms	-

reactive-element-list

Browser: chrome-headless 89.0.4389.114
Sample size: 50
Built by: Benchmarks #1261
Commit: 6a591c0

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	91.24ms - 94.45ms	-	unsure 🔍 -3% - +2% -2.80ms - +1.78ms	unsure 🔍 -1% - +4% -0.46ms - +3.43ms
tip-of-tree tip-of-tree	91.73ms - 94.98ms	unsure 🔍 -2% - +3% -1.78ms - +2.80ms	-	slower ❌ 0% - 4% 0.03ms - 3.96ms
previous-release previous-release	90.26ms - 92.46ms	unsure 🔍 -4% - +0% -3.43ms - +0.46ms	faster ✔ 0% - 4% 0.03ms - 3.96ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1098.29ms - 1120.27ms	-	unsure 🔍 -1% - +2% -9.86ms - +22.45ms	unsure 🔍 -1% - +2% -12.88ms - +19.83ms
tip-of-tree tip-of-tree	1091.14ms - 1114.83ms	unsure 🔍 -2% - +1% -22.45ms - +9.86ms	-	unsure 🔍 -2% - +1% -19.76ms - +14.12ms
previous-release previous-release	1093.69ms - 1117.92ms	unsure 🔍 -2% - +1% -19.83ms - +12.88ms	unsure 🔍 -1% - +2% -14.12ms - +19.76ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1197.52ms - 1218.45ms	-	unsure 🔍 -2% - +1% -24.45ms - +11.27ms	unsure 🔍 -1% - +1% -13.27ms - +15.61ms
tip-of-tree tip-of-tree	1200.09ms - 1229.06ms	unsure 🔍 -1% - +2% -11.27ms - +24.45ms	-	unsure 🔍 -1% - +2% -9.81ms - +25.33ms
previous-release previous-release	1196.86ms - 1216.77ms	unsure 🔍 -1% - +1% -15.61ms - +13.27ms	unsure 🔍 -2% - +1% -25.33ms - +9.81ms	-

_{tachometer-reporter-action v2 for Benchmarks}

abdonrd · 2021-04-14T07:45:21Z

Isn't everything in the labs folder considered experimental?

kevinpschaaf · 2021-04-14T08:03:58Z

Isn't everything in the labs folder considered experimental?

Yes, however the lit/hydrate.js and lit/hydrate-support.js modules aren't themselves in labs, and decoupling them enough to move to a separate package would cause us to make more core library symbols public (and non-minifiable) than we'd like.

abdonrd · 2021-04-14T08:12:25Z

Isn't everything in the labs folder considered experimental?

Yes, however the lit/hydrate.js and lit/hydrate-support.js modules aren't themselves in labs, and decoupling them enough to move to a separate package would cause us to make more core library symbols public (and non-minifiable) than we'd like.

Oh, you're totally right! I don't know why I thought everything was in labs. Thanks!

kevinpschaaf · 2021-04-14T08:57:18Z

Yeah, the server-side SSR module itself is in labs, so you can't use hydrate without using @lit-labs/ssr, but as a pragmatic decision we're leaving hydration code in the core, and just want to be clear that we don't consider those API's to be totally stable yet, although the lit package itself will otherwise be.

sorvell

Looks good. Just one question.

sorvell · 2021-04-14T14:47:25Z

packages/labs/ssr-client/package.json

    "build:ts": "tsc --build && treemirror development . '**/*.d.ts{,.map}'",
    "build:ts:watch": "tsc --build --watch",
-    "clean": "rm -rf {index,hydrate-support,hydrate}.{js,js.map,d.ts} directives/ development/ test/ *.tsbuildinfo",
+    "clean": "rm -rf {index}.{js,js.map,d.ts} directives/ development/ test/ *.tsbuildinfo",


Was hydrate there mistakenly before?

Yeah, vestigial from when I tried moving them there earlier, missed removing it.

Rename hydrate & hydrate-support to "experimental"

2900150

kevinpschaaf requested a review from justinfagnani as a code owner April 14, 2021 05:14

google-cla bot added the cla: yes label Apr 14, 2021

Update CHANGELOGs

c92c435

kevinpschaaf changed the title ~~Rename hydrate & hydrate-support to "experimental"~~ [lit-next] Rename hydrate & hydrate-support to "experimental" Apr 14, 2021

kevinpschaaf mentioned this pull request Apr 14, 2021

[lit-ssr] Add defer-hydration protocol for coordinating host/child hydration #1388

Merged

sorvell approved these changes Apr 14, 2021

View reviewed changes

kevinpschaaf merged commit 98fff04 into lit-next Apr 14, 2021

kevinpschaaf deleted the lit-next-experimental-hydrate branch April 14, 2021 20:05

justinfagnani approved these changes Apr 14, 2021

View reviewed changes

Conversation

kevinpschaaf commented Apr 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

abdonrd commented Apr 14, 2021

Uh oh!

kevinpschaaf commented Apr 14, 2021

Uh oh!

abdonrd commented Apr 14, 2021

Uh oh!

kevinpschaaf commented Apr 14, 2021

Uh oh!

sorvell left a comment

Choose a reason for hiding this comment

Uh oh!

sorvell Apr 14, 2021

Choose a reason for hiding this comment

Uh oh!

kevinpschaaf Apr 14, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kevinpschaaf commented Apr 14, 2021 •

edited

Loading

github-actions bot commented Apr 14, 2021 •

edited

Loading