Skip to content

[lit-html] RefOrCallback should be generic #3966

@justinfagnani

Description

@justinfagnani

Which package(s) are affected?

Lit Core (lit / lit-html / lit-element / reactive-element)

Description

RefOrCallback is not generic like Ref<T> and so does not forward a ref element type to Ref:

export type RefOrCallback = Ref | ((el: Element | undefined) => void);

This should be:

export type RefOrCallback<T = Element> = Ref<T> | ((el: T | undefined) => void);

Reproduction

n/a

Workaround

Make your own type.

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Affected versions

2.x

Browser/OS/Node environment

all

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions