Skip to content

Commit fcaf8cb

Browse files
justinfagnanijustinfagnani
committed
Merge branch main into 3.0
1 parent 5597e01 commit fcaf8cb

138 files changed

Lines changed: 3776 additions & 478 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.changeset/analyzer-circular-reexports.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@lit-labs/analyzer': patch
3+
---
4+
5+
Analyzer can now handle module graphs which reexport names from their circular dependencies

‎.changeset/few-cups-hammer.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

‎.changeset/gentle-pillows-buy.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@lit-labs/context': major
3+
---
4+
5+
Late loaded elements can take over the context subscriptions for their children.
6+
7+
Breaking change: ValueNotifier.addCallback now takes the consuming element as a mandatory second argument.

‎.changeset/yellow-pianos-peel.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

‎.eslintignore‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@ packages/benchmarks/**/*.d.ts.map
2424
packages/benchmarks/**/*.js
2525
packages/benchmarks/**/*.js.map
2626

27-
packages/compiler/development/
28-
packages/compiler/node_modules/
29-
packages/compiler/test/
30-
packages/compiler/lib/
31-
3227
packages/internal-scripts/node_modules/
3328
packages/internal-scripts/lib/
3429

@@ -171,6 +166,12 @@ packages/labs/cli/test-gen/
171166
packages/labs/cli-localize/lib/
172167
packages/labs/cli-localize/node_modules/
173168

169+
packages/labs/compiler/**/test_files
170+
packages/labs/compiler/development/
171+
packages/labs/compiler/node_modules/
172+
packages/labs/compiler/test/
173+
packages/labs/compiler/lib/
174+
174175
packages/labs/context/development/
175176
packages/labs/context/test/
176177
packages/labs/context/node_modules/
@@ -311,8 +312,10 @@ packages/labs/ssr-react/enable-lit-ssr.*
311312
packages/labs/task/development/
312313
packages/labs/task/test/
313314
packages/labs/task/node_modules/
315+
packages/labs/task/deep-equals.*
314316
packages/labs/task/index.*
315317
packages/labs/task/task.*
318+
316319
packages/labs/testing/index.*
317320
packages/labs/testing/fixtures.*
318321
packages/labs/testing/web-test-runner-ssr-plugin.*

‎.github/workflows/benchmarks-report.yaml‎

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
name: Report Benchmark Results
2+
3+
on:
4+
workflow_run:
5+
workflows: [Benchmarks]
6+
branches: ['**']
7+
types:
8+
- completed
9+
- requested
10+
11+
jobs:
12+
# Optional job to update existing comments with a "benchmarks are running" text
13+
report_running:
14+
name: Report benchmarks are in-progress
15+
runs-on: ubuntu-latest
16+
# Only add the "benchmarks are running" text when the workflow_run starts
17+
if: ${{ github.event.action == 'requested' }}
18+
steps:
19+
- name: Report Tachometer Running
20+
uses: andrewiggins/tachometer-reporter-action@v2
21+
with:
22+
# Set initialize true so this action just creates the comment and adds
23+
# the "benchmarks are running" text
24+
initialize: true
25+
26+
report_results:
27+
name: Report benchmark results
28+
runs-on: ubuntu-latest
29+
# Only run this job if the event action was "completed" and the triggering
30+
# workflow_run was successful
31+
if: ${{ github.event.action == 'completed' && github.event.workflow_run.conclusion == 'success' }}
32+
steps:
33+
# Download the artifact from the triggering workflow that contains the
34+
# Tachometer results to report
35+
- uses: dawidd6/action-download-artifact@v2
36+
with:
37+
workflow: ${{ github.event.workflow.id }}
38+
run_id: ${{ github.event.workflow_run.id }}
39+
name: results
40+
path: results
41+
42+
# Create/update the comment with the latest results
43+
- name: Report Tachometer Results
44+
uses: andrewiggins/tachometer-reporter-action@main
45+
with:
46+
path: results/*.json
47+
pr-bench-name: this-change
48+
base-bench-name: tip-of-tree

‎.github/workflows/benchmarks.yml‎

Lines changed: 14 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@ on: [pull_request]
44

55
jobs:
66
benchmarks:
7-
# Don't run on forks. Benchmarks can't run on forks because secrets aren't
8-
# available, which are needed for posting result comments.
9-
if: github.event.pull_request.head.repo.id == github.event.pull_request.base.repo.id
10-
117
name: benchmarks
128

139
runs-on: ubuntu-latest
@@ -51,76 +47,47 @@ jobs:
5147
cd packages/benchmarks
5248
npx tachometer \
5349
--config lit-html/kitchen-sink/tachometer.json \
54-
--json-file lit-html/kitchen-sink/results.json
55-
56-
- name: Report lit-html-kitchen-sink
57-
uses: andrewiggins/tachometer-reporter-action@v2
58-
with:
59-
report-id: lit-html-kitchen-sink
60-
path: packages/benchmarks/lit-html/kitchen-sink/results.json
61-
pr-bench-name: this-change
62-
base-bench-name: tip-of-tree
50+
--json-file lit-html-kitchen-sink.json
6351
6452
# lit-html:template-heavy
6553
- name: Benchmark lit-html/template-heavy
6654
run: |
6755
cd packages/benchmarks
6856
npx tachometer \
6957
--config lit-html/template-heavy/tachometer.json \
70-
--json-file lit-html/template-heavy/results.json
71-
72-
- name: Report lit-html-template-heavy
73-
uses: andrewiggins/tachometer-reporter-action@v2
74-
with:
75-
report-id: lit-html-template-heavy
76-
path: packages/benchmarks/lit-html/template-heavy/results.json
77-
pr-bench-name: this-change
78-
base-bench-name: tip-of-tree
58+
--json-file lit-html-template-heavy.json
7959
8060
# lit-html:repeat
8161
- name: Benchmark lit-html/repeat
8262
run: |
8363
cd packages/benchmarks
8464
npx tachometer \
8565
--config lit-html/repeat/tachometer.json \
86-
--json-file lit-html/repeat/results.json
87-
88-
- name: Report lit-html-repeat
89-
uses: andrewiggins/tachometer-reporter-action@v2
90-
with:
91-
report-id: lit-html-repeat
92-
path: packages/benchmarks/lit-html/repeat/results.json
93-
pr-bench-name: this-change
94-
base-bench-name: tip-of-tree
66+
--json-file lit-html-repeat.json
9567
9668
# lit-element:list
9769
- name: Benchmark lit-element/list
9870
run: |
9971
cd packages/benchmarks
10072
npx tachometer \
10173
--config lit-element/list/tachometer.json \
102-
--json-file lit-element/list/results.json
103-
104-
- name: Report lit-element-list
105-
uses: andrewiggins/tachometer-reporter-action@v2
106-
with:
107-
report-id: lit-element-list
108-
path: packages/benchmarks/lit-element/list/results.json
109-
pr-bench-name: this-change
110-
base-bench-name: tip-of-tree
74+
--json-file lit-element-list.json
11175
11276
# reactive-element:list
11377
- name: Benchmark reactive-element/list
11478
run: |
11579
cd packages/benchmarks
11680
npx tachometer \
11781
--config reactive-element/list/tachometer.json \
118-
--json-file reactive-element/list/results.json
82+
--json-file reactive-element-list.json
11983
120-
- name: Report reactive-element-list
121-
uses: andrewiggins/tachometer-reporter-action@v2
84+
- name: Upload results
85+
uses: actions/upload-artifact@v3
12286
with:
123-
report-id: reactive-element-list
124-
path: packages/benchmarks/reactive-element/list/results.json
125-
pr-bench-name: this-change
126-
base-bench-name: tip-of-tree
87+
name: results
88+
path: |
89+
packages/benchmarks/lit-html-kitchen-sink.json
90+
packages/benchmarks/lit-html-template-heavy.json
91+
packages/benchmarks/lit-html-repeat.json
92+
packages/benchmarks/lit-element-list.json
93+
packages/benchmarks/reactive-element-list.json

‎.prettierignore‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@ packages/benchmarks/**/*.d.ts.map
2424
packages/benchmarks/**/*.js
2525
packages/benchmarks/**/*.js.map
2626

27-
packages/compiler/development/
28-
packages/compiler/node_modules/
29-
packages/compiler/test/
30-
packages/compiler/lib/
31-
3227
packages/internal-scripts/node_modules/
3328
packages/internal-scripts/lib/
3429

@@ -158,6 +153,13 @@ packages/labs/cli/test-goldens/
158153
packages/labs/cli-localize/lib/
159154
packages/labs/cli-localize/node_modules/
160155

156+
packages/labs/compiler/development/
157+
packages/labs/compiler/node_modules/
158+
packages/labs/compiler/test/
159+
packages/labs/compiler/lib/
160+
161+
packages/labs/compiler/**/test_files
162+
161163
packages/labs/context/development/
162164
packages/labs/context/test/
163165
packages/labs/context/node_modules/
@@ -298,8 +300,10 @@ packages/labs/ssr-react/enable-lit-ssr.*
298300
packages/labs/task/development/
299301
packages/labs/task/test/
300302
packages/labs/task/node_modules/
303+
packages/labs/task/deep-equals.*
301304
packages/labs/task/index.*
302305
packages/labs/task/task.*
306+
303307
packages/labs/testing/index.*
304308
packages/labs/testing/fixtures.*
305309
packages/labs/testing/web-test-runner-ssr-plugin.*

0 commit comments

Comments
 (0)