[reactive-element] remove unused internal parameters to requestUpdate (#4413)

justinfagnani · AndrewJakubowicz · web-flow · commit f60a3a2c994f · 2023-11-27T17:01:58.000-08:00
Co-authored-by: Andrew Jakubowicz &lt;spyr1014@gmail.com&gt;
diff --git a/.changeset/odd-buckets-attend.md b/.changeset/odd-buckets-attend.md
@@ -0,0 +1,7 @@
+---
+'@lit/reactive-element': patch
+'lit-element': patch
+'lit': patch
+---
+
+Remove unused internal parameters to `requestUpdate()`
diff --git a/packages/reactive-element/src/reactive-element.ts b/packages/reactive-element/src/reactive-element.ts
@@ -1237,30 +1237,20 @@ export abstract class ReactiveElement
    * @param oldValue old value of requesting property
    * @param options property options to use instead of the previously
    *     configured options
-   * @param initial whether this call is for the initial value of the property.
-   *     Initial values do not reflect to an attribute.
    * @category updates
    */
   requestUpdate(
     name?: PropertyKey,
     oldValue?: unknown,
     options?: PropertyDeclaration
-  ): void;
-  /* @internal */
-  requestUpdate(
-    name?: PropertyKey,
-    oldValue?: unknown,
-    options?: PropertyDeclaration,
-    initial = false,
-    initialValue?: unknown
   ): void {
     // If we have a property key, perform property update steps.
     if (name !== undefined) {
       options ??= (
         this.constructor as typeof ReactiveElement
       ).getPropertyOptions(name);
       const hasChanged = options.hasChanged ?? notEqual;
-      const newValue = initial ? initialValue : this[name as keyof this];
+      const newValue = this[name as keyof this];
       if (hasChanged(newValue, oldValue)) {
         this._$changeProperty(name, oldValue, options);
       } else {
diff --git a/scripts/check-size.js b/scripts/check-size.js
@@ -9,7 +9,7 @@ import * as fs from 'fs';
 // it's likely that we'll ask you to investigate ways to reduce the size.
 //
 // In either case, update the size here and push a new commit to your PR.
-const expectedLitCoreSize = 15447;
+const expectedLitCoreSize = 15436;
 const expectedLitHtmlSize = 7250;
 
 const litCoreSrc = fs.readFileSync('packages/lit/lit-core.min.js', 'utf8');
