Skip to content

Dep up electron#1325

Merged
listen1 merged 4 commits intolisten1:masterfrom
mikelxk:dep-up-electron
Apr 1, 2025
Merged

Dep up electron#1325
listen1 merged 4 commits intolisten1:masterfrom
mikelxk:dep-up-electron

Conversation

@mikelxk
Copy link
Copy Markdown
Collaborator

@mikelxk mikelxk commented Mar 2, 2025

Up Electron to 32, the last version that supports Catalina

Todos:
Migrate to use esm in electron to improve performance

Fix: #1250

@listen1 listen1 merged commit d48d74c into listen1:master Apr 1, 2025
@listen1
Copy link
Copy Markdown
Owner

listen1 commented Apr 1, 2025

New electron cause search function not working for some platform (netease, bilibili). Please try to test more to find bugs due to electron version upgrade, thanks.

@mikelxk
Copy link
Copy Markdown
Collaborator Author

mikelxk commented Apr 1, 2025

New electron cause search function not working for some platform (netease, bilibili). Please try to test more to find bugs due to electron version upgrade, thanks.

I will take a look at this later today.

@listen1
Copy link
Copy Markdown
Owner

listen1 commented Apr 1, 2025

New electron cause search function not working for some platform (netease, bilibili). Please try to test more to find bugs due to electron version upgrade, thanks.

I will take a look at this later today.

thanks, maybe the reason is not electron upgrade, i'm still testing.

@mikelxk
Copy link
Copy Markdown
Collaborator Author

mikelxk commented Apr 2, 2025

New electron cause search function not working for some platform (netease, bilibili). Please try to test more to find bugs due to electron version upgrade, thanks.

I will take a look at this later today.

thanks, maybe the reason is not electron upgrade, i'm still testing.

That's my response from https://music.163.com/api/search/pc

{
    "code": -462,
    "data": {
        "actionCode": null,
        "verifyType": 50,
        "verifyId": 1008601,
        "verifyUrl": "",
        "blockText": "绑定手机后,可进行下一步操作哦~",
        "verifyToken": null,
        "btnText": "",
        "orpheusUrl": "",
        "frontRuleIds": null,
        "params": {
            "event_id": "00615478792837337099",
            "sign": "c602652f5c42c9fadb1005cabc0705a5"
        },
        "url": null,
        "urlAutoOpen": 0,
        "orpheusUrlParamAppend": null
    },
    "message": "请绑定手机后再试哦~"
}

Doesn't seem to related to electron upgrade, maybe it's been so long since we update the api endpoints, some are failing.
Also, I added some code fix for electron remote in listen1/listen1_chrome_extension#1216
probably need to update submodule in that as well.

Update: revert back to 2.32 the issue is resolved, so some api check or cookie setter changed as I upgraded electron?
@listen1 The problem seems to relate to some Cookie are not sent from Electron cuz Chrome upgrade security policy
image
But I didn't find where that cookie was set, so could you please take a look at it? or we could downgrade to Electron 21 since that version in the next branch still works.

@listen1
Copy link
Copy Markdown
Owner

listen1 commented Apr 3, 2025

Nice work, and I submit a PR about that: listen1/listen1_chrome_extension#1220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MPRIS 接口的 Position 未被正确实现

2 participants