Skip to content

[BUG] - Fix some bugs with collecting words data #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomDonoghue merged 6 commits into from
Feb 28, 2021
Merged

[BUG] - Fix some bugs with collecting words data #61

TomDonoghue merged 6 commits into from
Feb 28, 2021

Conversation

@TomDonoghue
Copy link
Member

@TomDonoghue TomDonoghue commented Feb 28, 2021 •
edited
Loading

Fixes / updates in this PR:

  • refactors converting ids to str, which also helps to be robust to search with zero results
  • update accessing dates from Medline tag, being more robust to different formats
  • refactors history retmax, for cleanliness
  • adds a NotImplementedError to db's other than pubmed for words collection, as these don't work

@TomDonoghue TomDonoghue merged commit 8e6ba03 into main Feb 28, 2021
@TomDonoghue TomDonoghue deleted the colwords branch February 28, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomDonoghue