Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a "Notices" feature by refactoring the warning system in LiSA. The main changes include renaming Warning classes to Message classes, moving them from the checks.warnings package to the outputs.messages package, and introducing a separate collection for notices alongside warnings.
Key Changes:
- Renamed all
*Warningclasses to*Messageclasses and moved to new package - Added
noticescollection parallel towarningsthroughout the system - Added
notice*()methods inCheckToolto complement existingwarn*()methods - Updated all tests, reports, and comparison logic to handle both warnings and notices
Reviewed changes
Copilot reviewed 249 out of 251 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Message.java |
Renamed from Warning.java, updated package and documentation |
MessageWithLocation.java |
Renamed from WarningWithLocation.java, updated package and documentation |
*Message.java (subclasses) |
All warning subclasses renamed to message subclasses with updated docs |
CheckTool.java |
Added complete set of notice*() methods and notices collection |
LiSA.java, LiSARunner.java |
Updated to handle CheckTool instead of warnings collection |
LiSAReport.java, LiSARunInfo.java |
Added notices field and getter methods |
JsonReport.java |
Added notices field, renamed JsonWarning to JsonMessage |
ResultComparer.java |
Added notices comparison logic |
| Test files | Updated all test imports and class references |
| JSON report files | Added empty "notices" field to all test reports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lisa/lisa-sdk/src/main/java/it/unive/lisa/checks/syntactic/CheckTool.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented features
Closes #333