Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces significant improvements to the LiSA framework, focusing on type system enhancements, call graph resolution, and new analysis capabilities.
Key Changes:
- Refactored NumericType to use a flexible bit-count system via
getNBits()instead of individual boolean methods - Added CharacterType interface with supporting operators for character manipulation and validation
- Introduced extensive symbolic expression operators for strings, numerics, and characters
- Enhanced BaseCallGraph with distance-based target selection for improved call resolution
- Added ConstantValuePropagation analysis for tracking constant values across program execution
- Implemented Reachability analysis to track program point reachability
Reviewed changes
Copilot reviewed 90 out of 92 changed files in this pull request and generated 49 comments.
Show a summary per file
| File | Description |
|---|---|
| NumericType.java | Refactored bit-size checking to use getNBits() method with default implementations (contains critical bugs) |
| CharacterType.java | New interface for character types |
| Multiple operator files | Added 30+ new symbolic operators for strings, characters, and numeric operations |
| BaseCallGraph.java | Enhanced call resolution with distance-based target selection and improved documentation |
| TypeSystem.java | Added getCharacterType() and distanceBetweenTypes() methods |
| ConstantValuePropagation.java | New analysis for constant value propagation (contains critical bug) |
| Reachability.java, ReachLattice.java | New reachability analysis infrastructure |
| Character operator files | Two critical bugs in type inference returning BooleanType instead of CharacterType |
| Build and config files | Gradle wrapper deletions and build configuration adjustments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...lisa-sdk/src/main/java/it/unive/lisa/symbolic/value/operator/unary/CharacterToUpperCase.java
Outdated
Show resolved
Hide resolved
lisa/lisa-analyses/src/main/java/it/unive/lisa/analysis/ConstantValuePropagation.java
Outdated
Show resolved
Hide resolved
.../src/main/java/it/unive/lisa/symbolic/value/operator/ternary/StringLastIndexOfFromIndex.java
Outdated
Show resolved
Hide resolved
...dk/src/main/java/it/unive/lisa/symbolic/value/operator/unary/CharacterIsIdentifierStart.java
Outdated
Show resolved
Hide resolved
lisa/lisa-analyses/src/main/java/it/unive/lisa/analysis/numeric/Interval.java
Show resolved
Hide resolved
lisa/lisa-analyses/src/main/java/it/unive/lisa/analysis/numeric/Interval.java
Show resolved
Hide resolved
lisa/lisa-analyses/src/main/java/it/unive/lisa/analysis/numeric/Interval.java
Show resolved
Hide resolved
lisa/lisa-analyses/src/main/java/it/unive/lisa/analysis/numeric/Interval.java
Show resolved
Hide resolved
lisa/lisa-analyses/src/main/java/it/unive/lisa/analysis/numeric/Interval.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch carries improvements to: