Refactoring of non relational hierarchy and utilities#325
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the non-relational domain hierarchy and updates related utilities, causing many test fixtures to change default abstract-state values, and bumps several build and style tool versions.
- Test fixtures under
non-interference/confidentialityanddataflow/issue322updated to reflect new default “#TOP#” lattice values and added new JSON outputs. - Build scripts updated: equalsverifier → 3.19.4, Gradle wrapper → 8.10, Spotless plugin → 7.0.3, Javadoc lint suppressed, and code‐style indentation rule modified.
- Fixed
.gitignoreto remove an error line and add VS Code folder.
Reviewed Changes
Copilot reviewed 111 out of 111 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lisa/lisa-analyses/imp-testcases/non-interference/confidentiality/*.json | Updated many fixtures to use “#TOP#” for default abstract values. |
| lisa/lisa-analyses/imp-testcases/non-interference/confidentiality/report.json | Adjusted duration and timestamps. |
| lisa/lisa-analyses/imp-testcases/dataflow/issue322/*.json | Added new dataflow issue322 JSON outputs and report.json. |
| lisa/lisa-analyses/build.gradle | Bumped nl.jqno.equalsverifier to 3.19.4. |
| lisa/java.gradle | Added addStringOption('Xdoclint:none', '-quiet') to suppress Javadoc linting. |
| lisa/gradle/wrapper/gradle-wrapper.properties | Updated Gradle distribution to 8.10. |
| lisa/code-style.gradle | Changed Spotless indent rule from indentWithTabs() to leadingSpacesToTabs(). |
| lisa/build.gradle | Upgraded Spotless plugin to 7.0.3. |
| lisa/.gitignore | Removed erroneous line and added .vscode. |
Comments suppressed due to low confidence (2)
lisa/java.gradle:48
- [nitpick] Suppressing Javadoc lint is useful, but it may hide real documentation issues. Consider adding a comment explaining which warnings are suppressed and why, or selectively disabling specific checks.
addStringOption('Xdoclint:none', '-quiet')
lisa/code-style.gradle:34
- The method
leadingSpacesToTabs()is not a standard Spotless API and may not work as intended. Consider reverting toindentWithTabs()or using a supported indentation rule to ensure consistent formatting.
leadingSpacesToTabs()
.../confidentiality/untyped_Confidentiality.confidentiality_lec5ex1(Confidentiality__this).json
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplified class hierarchy of non-relational domains. Other utilities like lifting lattice operators to sets, and default implementations of satisfies.