Skip to content

Implementation of prefix, suffix, and char inclusion string abstract domains#242

Merged
lucaneg merged 81 commits intolisa-analyzer:masterfrom
BlueRyse:master
Nov 17, 2022
Merged

Implementation of prefix, suffix, and char inclusion string abstract domains#242
lucaneg merged 81 commits intolisa-analyzer:masterfrom
BlueRyse:master

Conversation

@VincenzoArceri
Copy link
Member

@VincenzoArceri VincenzoArceri commented Nov 15, 2022

Description
This pull request implements the prefix, suffix, and char inclusion string abstract domains, as described here.

Further content
The aforementioned domains just model the abstract semantics of operations concerning just strings (e.g., concatenation) and not the others (e.g., substring)

BlueRyse and others added 30 commits October 26, 2022 23:26
@BlueRyse
add first implementation of Prefix domain
bf2105e
@BlueRyse
add lessOrEqualAux implementation, isTop and isBottom overriding and …
139af68 
…refactoring
@BlueRyse
fix lubAux method and add PrefixTest class
c436df0
@BlueRyse
add test methods in PrefixTest and lubAux fix in Prefix
98bd836
@BlueRyse
remove * element in tests, code reformat and remove commented method
f800108
@BlueRyse
implement representation() method
824941f
@BlueRyse
add evalTernaryExpression implementation placeholder
a48d80f
@BlueRyse
fix indentation
cfcfd40
@BlueRyse
substring placeholder
58f8729
@BlueRyse
add first implementation of Suffix and SuffixTest
433b6f3
@BlueRyse
add more test methods in SuffixTest class and refactor
ea0f1b2
@BlueRyse
add constructor tests, evalTernaryExpression returns TOP
d3055f1
@BlueRyse
remove placeholder evalTernaryExpression, isTop() and isBottom() now …
3771145 
…uses equals method, remove unused imports
@BlueRyse
add testIsTop() and testIsBottom() methods, refactoring, removed unus…
2410f37 
…ed imports
@BlueRyse
add testIsTop() and testIsBottom() methods, refactoring
4508114
@BlueRyse
fix isTop() and isBottom() that now uses equals method
33081be
@BlueRyse
add first implementation of CharInclusion domain
acf18f2
@BlueRyse
refactoring, add TOP and BOTTOM fields and getAlphabet() method
1ed68c5
@VincenzoArceri
Merge branch 'lisa-analyzer:master' into prefix
d49d5dd
@VincenzoArceri
Merge branch 'lisa-analyzer:master' into suffix
aeb191c
@VincenzoArceri
Merge branch 'lisa-analyzer:master' into char_inclusion
147036c
@BlueRyse
add formatCharInclusionRepresentation() method, implement methods, ad…
a1b4016 
…d CharInclusionTest class
@BlueRyse
Merge remote-tracking branch 'origin/char_inclusion' into char_inclusion
e50cf62
@BlueRyse
fix visibility error and add missing comma
aed6166
@BlueRyse
refactoring, add lubAux implementation, fix formatRepresentation bug,…
ee0b34a 
… add lubAux test
@BlueRyse
fix visibility errors due to recent commits
bdb9205
@BlueRyse
fix visibility errors due to recent commits, remove TODO
bbf70e9
@BlueRyse
fix and optimize lessOrEqualAux and few small fixes
207d24a
@BlueRyse
luAuxTest uses charInclusion Object, add lessOrEqualAux tests and isT…
fb41197 
…op isBottom tests
@BlueRyse
implementation of satisfiesBinaryExpression and satisfiesTernaryExpre…
c7d9811 
…ssion methods
@VincenzoArceri VincenzoArceri added 🎆 type:feature New feature or request 🔍 scope:analysis Work regarding abstract domains or fixpoint algorithms labels Nov 15, 2022
@VincenzoArceri VincenzoArceri added this to the 0.1b8 milestone Nov 15, 2022
@VincenzoArceri VincenzoArceri self-assigned this Nov 15, 2022
@lucaneg
Copy link
Member

lucaneg commented Nov 15, 2022

Related to #232

lucaneg
lucaneg requested changes Nov 15, 2022
View reviewed changes
BlueRyse and others added 14 commits November 15, 2022 22:47
@BlueRyse
remove unnecessary to override methods, optimized formatRepresentatio…
34239dc 
…n() method
@BlueRyse
update representationTest()
761eaed
@BlueRyse
update cron tests
51bd28e
@BlueRyse
spotless apply
50e05da
@BlueRyse
removed unnecessary to override methods
3ad2ce7
@BlueRyse
removed unnecessary to override methods, change visibility to getSuff…
a9618b1 
…ix()
@BlueRyse
remove isTop() and isBottom() tests
7c89f4a
@BlueRyse
access suffix field without getter method
0eb3a6e
@BlueRyse
update suffix cron test
20f6e41
@BlueRyse
access prefix field without getter method
5cada1b
@BlueRyse
access CharInclusion fields without getters methdos
acfc538
@BlueRyse
make getPrefix() public
0ba43b0
@VincenzoArceri
Restore isTop method in Prefix and Suffix domains
96ebce0
@VincenzoArceri
Fix evalNonNullConstant methods of Prefix and Suffix domains when the
ce8f8bc 
argument is the empty string, remove isTop methods from Prefix and
Suffix domains (they rely on the default one)
@lucaneg lucaneg merged commit 0cb1b56 into lisa-analyzer:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaneg lucaneg lucaneg approved these changes

+1 more reviewer

@BlueRyse BlueRyse BlueRyse left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@VincenzoArceri VincenzoArceri

Labels

🔍 scope:analysis Work regarding abstract domains or fixpoint algorithms 🎆 type:feature New feature or request

Projects

LiSA
Archived in project

Milestone

0.1b8

Development

Successfully merging this pull request may close these issues.

3 participants

@VincenzoArceri @lucaneg @BlueRyse