Merged
Conversation
SimpleAbstractState.Set glb as default for narrowing in class Lattice
handling this exception
Interval.satisfiesBinaryExpression
Conflicts: lisa/lisa-core/imp-testcases/interval/untyped_tutorial.intv_dec(tutorial__this).json lisa/lisa-core/src/main/java/it/unive/lisa/LiSAConfiguration.java lisa/lisa-core/src/main/java/it/unive/lisa/LiSARunner.java lisa/lisa-core/src/main/java/it/unive/lisa/analysis/heap/pointbased/PointBasedHeap.java lisa/lisa-core/src/main/java/it/unive/lisa/interprocedural/CFGResults.java lisa/lisa-sdk/src/main/java/it/unive/lisa/analysis/nonrelational/heap/HeapEnvironment.java lisa/lisa-sdk/src/main/java/it/unive/lisa/outputs/compare/JsonReportComparer.java lisa/lisa-sdk/src/main/java/it/unive/lisa/program/cfg/statement/global/AccessInstanceGlobal.java lisa/lisa-sdk/src/main/java/it/unive/lisa/type/ReferenceType.java
descending algorithms
lucaneg
requested changes
Nov 11, 2022
lisa/lisa-core/src/main/java/it/unive/lisa/analysis/combination/ValueCartesianProduct.java
Outdated
Show resolved
Hide resolved
lisa/lisa-sdk/src/main/java/it/unive/lisa/analysis/dataflow/DefiniteForwardDataflowDomain.java
Outdated
Show resolved
Hide resolved
lisa/lisa-sdk/src/main/java/it/unive/lisa/analysis/dataflow/PossibleForwardDataflowDomain.java
Outdated
Show resolved
Hide resolved
lisa/lisa-sdk/src/main/java/it/unive/lisa/analysis/nonrelational/Environment.java
Outdated
Show resolved
Hide resolved
ValueEnvironment that lubs the stacks values to.
lucaneg
requested changes
Nov 14, 2022
lisa/lisa-sdk/src/main/java/it/unive/lisa/analysis/nonrelational/value/ValueEnvironment.java
Show resolved
Hide resolved
to the original form. There are no more the join and meet method in the FixpointImplementation interface, but a single operation method. In CFG , the operation and equality method of the CFGFixpointImplementation class use some FunctionalInterface that are passed to it at creation. So that in the ascending phase lub, widening and the right equality evaluation are passed and in the descending phase glb, narrowing and the right equality evaluation are passed.
which phase it is in (similarly for the equality method). The method fixpoint in the class Fixpoint now accept a parameter to initialize the rusult.
lucaneg
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements the analysis descending phase. It relies on the narrowing operator for its convergence.
Fixed bugs and implemented features
Closes #117