Implementation of common statements and types#129
Merged
VincenzoArceri merged 15 commits intomasterfrom Oct 1, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Cron Test Results10 files 10 suites 4s ⏱️ Results for commit 703e715. |
Unit Test Results 33 files 33 suites 12s ⏱️ Results for commit b54cfbb. |
This comment has been minimized.
This comment has been minimized.
VincenzoArceri
approved these changes
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides implementations for common statements and types, avoiding the need for separate (but likely equal) implementations in each frontend.
Added types:
BoolTypeStringTypeInt8,Int16,Int32,Int64UInt8,UInt16,UInt32,UInt64Float32,Float64Added statements:
Equal,GreaterOrEqual,GreaterThan,LessOrEqual,LessThan,NotEqualStringLiteral,TrueLiteral,FalseLiteral,Int8Literal,Int16Literal,Int32Literal,Int64Literal,NullLiteral,UInt8Literal,UInt16Literal,UInt32Literal,UInt64Literal,Float32Literal,Float64LiteralAnd,Not,OrAddition,Division,Multiplication,Negation,Remainder,SubtractionConcat,Contains,EndsWith,Equals,IndexOf,Length,Replace,StartsWith,SubstringImplemented features
Closes #113