-
Notifications
You must be signed in to change notification settings - Fork 35
Closed
Labels
‼ priority:p1Priority planning - level 1Priority planning - level 1🌍 scope:interprocWork regarding interprocedural analyses or call graphsWork regarding interprocedural analyses or call graphs🎊 resolution:resolvedBug or feature resolved - might not have been merged to master yetBug or feature resolved - might not have been merged to master yet🐛 type:bugSomething isn't workingSomething isn't working
Milestone
Description
Description
HybridCall is performing assigning to NativeCFGs parameters as we would do for calls to regular CFGs,
but:
- the assignment is not needed: the rewritten expression will not access the values by trying to access the names of the instrumented cfg, but just by their position in the array of
ExpressionSets - the assignment is not cleaned later: while will regular calls we push and pop scopes to remove variables when we switch contexts, we'd need to forget these parameters being assigned with manual calls to
forgetIdentifiers, adding unneeded complexity to the analysis
At this point it's just better to remove the assignments entirely.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
‼ priority:p1Priority planning - level 1Priority planning - level 1🌍 scope:interprocWork regarding interprocedural analyses or call graphsWork regarding interprocedural analyses or call graphs🎊 resolution:resolvedBug or feature resolved - might not have been merged to master yetBug or feature resolved - might not have been merged to master yet🐛 type:bugSomething isn't workingSomething isn't working