Skip to content

Pin certbot to 1.32.0 until plugin compatibility improves#299

Merged
nemchik merged 1 commit intomasterfrom
pin-certbot
Nov 22, 2022
Merged

Pin certbot to 1.32.0 until plugin compatibility improves#299
nemchik merged 1 commit intomasterfrom
pin-certbot

Conversation

@nemchik
Copy link
Copy Markdown
Member

@nemchik nemchik commented Nov 22, 2022

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

thespad
thespad approved these changes Nov 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@thespad thespad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

LinuxServer-CI commented Nov 22, 2022

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.0.0-pkg-bdbf434a-pr-299/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.0.0-pkg-bdbf434a-pr-299/shellcheck-result.xml

thespad
thespad requested changes Nov 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@thespad thespad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's still going to label the image version as 2.0.0 and will trigger on 2.0.1, etc. You might want to change the versioning in jenkins-vars to build and tag 1.32.0 with a custom release type and "echo 1.32.0"

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

LinuxServer-CI commented Nov 22, 2022

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.0.0-pkg-bdbf434a-pr-299/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.0.0-pkg-bdbf434a-pr-299/shellcheck-result.xml

@nemchik nemchik mentioned this pull request Nov 22, 2022
Closed
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

LinuxServer-CI commented Nov 22, 2022

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-bdbf434a-pr-299/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/1.32.0-pkg-bdbf434a-pr-299/shellcheck-result.xml

@thespad thespad linked an issue Nov 22, 2022 that may be closed by this pull request
Problem with certbot version 2.0.0 #297
Closed
@nemchik nemchik merged commit 588dde9 into master Nov 22, 2022
@nemchik nemchik deleted the pin-certbot branch November 22, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thespad thespad thespad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problem with certbot version 2.0.0

3 participants

@nemchik @LinuxServer-CI @thespad