Switch zoom buttons in toolbar #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It's this way to stay consistent. The current layout is the same as in the Xapp image viewer and pix. It shouldn't be different here. |
Member
Author
|
In all applications I know it's like this. Also, if an application uses a zoom slider, the bigger zoom is always on the right. |
Member
|
@Cobinja please rebase. |
Member
|
You both have a point I think. For consistency we should change this in xviewer and pix also. |
Previously: "In" was left, "Out" was right, now: "Out" is left, "In" is right
5a3b4c1 to
eeb4ab2
Compare
Member
Author
|
Rebased to current master |
Member
Author
|
Based on which PR is merged first (this or #132), the other one may have to be rebased again. |
This was referenced Aug 30, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: "In" was left, "Out" was right,
now: "Out" is left, "In" is right