Skip to content

Commit d79add2

Browse files
committed
refactor(processor): inline processWithStandardFilters into processWithFilters
- Remove single-line delegation wrapper that added unnecessary indirection - Merge documentation from both functions into processWithFilters - Eliminate processWithStandardFilters function entirely
1 parent f4d6b47 commit d79add2

1 file changed

Lines changed: 1 addition & 8 deletions

File tree

internal/processor/processor.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,18 +123,11 @@ type ProcessingResult struct {
123123
NormResult *NormalisationResult // nil if normalisation disabled or skipped
124124
}
125125

126-
// processWithFilters performs the actual audio processing with the complete filter chain.
126+
// processWithFilters performs audio processing using the standard single-input filter graph.
127127
// Applies the filter chain built by BuildFilterSpec() which includes asendcmd for noise profile learning
128128
// when NoiseProfileStart/End timestamps are set in the config.
129129
// If outputMeasurements is non-nil and config.OutputAnalysisEnabled is true, populates it with Pass 2 output analysis.
130130
func processWithFilters(inputPath, outputPath string, config *FilterChainConfig, progressCallback func(pass int, passName string, progress float64, level float64, measurements *AudioMeasurements), measurements *AudioMeasurements, outputMeasurements **OutputMeasurements) error {
131-
return processWithStandardFilters(inputPath, outputPath, config, progressCallback, measurements, outputMeasurements)
132-
}
133-
134-
// processWithStandardFilters performs audio processing using the standard single-input filter graph.
135-
// If outputMeasurements is non-nil and config.OutputAnalysisEnabled is true, populates it with Pass 2 output analysis.
136-
// For Pass 2 with loudnorm enabled, also captures loudnorm's measurement JSON for use in Pass 3.
137-
func processWithStandardFilters(inputPath, outputPath string, config *FilterChainConfig, progressCallback func(pass int, passName string, progress float64, level float64, measurements *AudioMeasurements), measurements *AudioMeasurements, outputMeasurements **OutputMeasurements) error {
138131
// Open input audio file
139132
reader, metadata, err := audio.OpenAudioFile(inputPath)
140133
if err != nil {

0 commit comments

Comments
 (0)