fix(processor): prevent panic in silence region test by using fatalf

flexiondotorg · flexiondotorg · commit cff086bcd83d · 2026-03-14T08:58:28.000Z
Replace t.Errorf with t.Fatalf at line 692 in
TestFindBestSilenceRegion_LateCandidateDiscoverable. The test checks
that candidates is non-empty before indexing; using Errorf logs failure
but continues to the unsafe access, causing a panic. Fatalf stops
immediately with a clear message if the assertion fails.

Signed-off-by: Martin Wimpress &lt;code@wimpress.io&gt;
diff --git a/internal/processor/analyzer_test.go b/internal/processor/analyzer_test.go
@@ -690,7 +690,7 @@ func TestFindBestSilenceRegion_LateCandidateDiscoverable(t *testing.T) {
 		t.Errorf("BestRegion.Start = %v, want 1800s", result.BestRegion.Start)
 	}
 	if len(result.Candidates) != 1 {
-		t.Errorf("len(Candidates) = %d, want 1", len(result.Candidates))
+		t.Fatalf("len(Candidates) = %d, want 1", len(result.Candidates))
 	}
 
 	t.Logf("late candidate score=%.4f", result.Candidates[0].Score)

Original file line number	Diff line number	Diff line change
`@@ -690,7 +690,7 @@ func TestFindBestSilenceRegion_LateCandidateDiscoverable(t *testing.T) {`
`690`	`690`	`t.Errorf("BestRegion.Start = %v, want 1800s", result.BestRegion.Start)`
`691`	`691`	`}`
`692`	`692`	`if len(result.Candidates) != 1 {`
`693`		`- t.Errorf("len(Candidates) = %d, want 1", len(result.Candidates))`
	`693`	`+ t.Fatalf("len(Candidates) = %d, want 1", len(result.Candidates))`
`694`	`694`	`}`
`695`	`695`
`696`	`696`	`t.Logf("late candidate score=%.4f", result.Candidates[0].Score)`