fix(audio): rename Seek to SeekTo to resolve interface conflict

flexiondotorg · flexiondotorg · commit b99cd12d6b98 · 2026-03-13T16:55:42.000Z
The Seek method signature conflicted with Go's standard io.Seeker
interface, which expects Seek(int64, int) (int64, error). This method
uses different semantics (timestamp-based seeking rather than
byte-offset seeking), making the name conflict confusing.

Renaming to SeekTo clarifies the intent and eliminates the interface
signature mismatch caught by go vet.

- Rename Seek(int64) error to SeekTo(int64) error in reader.go
- Update call site in analyzer_output.go

Signed-off-by: Martin Wimpress &lt;code@wimpress.io&gt;
diff --git a/internal/audio/reader.go b/internal/audio/reader.go
@@ -187,7 +187,7 @@ func (r *Reader) GetDecoderContext() *ffmpeg.AVCodecContext {
 // Seek seeks to the specified timestamp in AV_TIME_BASE units.
 // Use 0 to seek to the beginning of the file. After seeking, the decoder
 // buffers are flushed so that subsequent ReadFrame calls return fresh data.
-func (r *Reader) Seek(timestamp int64) error {
+func (r *Reader) SeekTo(timestamp int64) error {
 	if _, err := ffmpeg.AVFormatSeekFile(r.fmtCtx, -1, math.MinInt64, timestamp, math.MaxInt64, 0); err != nil {
 		return fmt.Errorf("failed to seek: %w", err)
 	}
diff --git a/internal/processor/analyzer_output.go b/internal/processor/analyzer_output.go
@@ -234,7 +234,7 @@ func MeasureOutputRegions(outputPath string, silenceRegion *SilenceRegion, speec
 	if speechRegion != nil {
 		if silenceRegion != nil {
 			// Only need to seek if we already read through the file for silence
-			if err := reader.Seek(0); err != nil {
+			if err := reader.SeekTo(0); err != nil {
 				debugLog("Warning: Failed to seek for speech region measurement: %v", err)
 				return silenceMetrics, nil
 			}

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ func (r Reader) GetDecoderContext() ffmpeg.AVCodecContext {`
`187`	`187`	`// Seek seeks to the specified timestamp in AV_TIME_BASE units.`
`188`	`188`	`// Use 0 to seek to the beginning of the file. After seeking, the decoder`
`189`	`189`	`// buffers are flushed so that subsequent ReadFrame calls return fresh data.`
`190`		`-func (r *Reader) Seek(timestamp int64) error {`
	`190`	`+func (r *Reader) SeekTo(timestamp int64) error {`
`191`	`191`	`if _, err := ffmpeg.AVFormatSeekFile(r.fmtCtx, -1, math.MinInt64, timestamp, math.MaxInt64, 0); err != nil {`
`192`	`192`	`return fmt.Errorf("failed to seek: %w", err)`
`193`	`193`	`}`
Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ func MeasureOutputRegions(outputPath string, silenceRegion *SilenceRegion, speec`
`234`	`234`	`if speechRegion != nil {`
`235`	`235`	`if silenceRegion != nil {`
`236`	`236`	`// Only need to seek if we already read through the file for silence`
`237`		`- if err := reader.Seek(0); err != nil {`
	`237`	`+ if err := reader.SeekTo(0); err != nil {`
`238`	`238`	`debugLog("Warning: Failed to seek for speech region measurement: %v", err)`
`239`	`239`	`return silenceMetrics, nil`
`240`	`240`	`}`