refactor(logging): hide rejected silence candidates in analysis output

flexiondotorg · flexiondotorg · commit 657d232c9932 · 2026-03-14T10:24:20.000Z
- Skip display of zero-scored candidates in both console and report
- Remove "rejected: too loud" annotation; zero score indicates rejection
- Improves clarity by showing only viable candidates

Signed-off-by: Martin Wimpress &lt;code@wimpress.io&gt;
diff --git a/internal/logging/analysis_display.go b/internal/logging/analysis_display.go
@@ -101,13 +101,23 @@ func DisplayAnalysisResults(w io.Writer, inputPath string, metadata *audio.Metad
 			writeSilenceCandidateMetrics(w, c)
 			fmt.Fprintln(w)
 
-			// Print remaining candidates
-			if len(measurements.SilenceCandidates) > 1 {
+			// Print remaining candidates (skip zero-scored rejected candidates)
+			visibleCount := 0
+			for i, c := range measurements.SilenceCandidates {
+				if i == electedIdx || c.Score == 0.0 {
+					continue
+				}
+				visibleCount++
+			}
+			if visibleCount > 0 {
 				fmt.Fprintf(w, "  OTHER CANDIDATES\n")
 				for i, c := range measurements.SilenceCandidates {
 					if i == electedIdx {
 						continue
 					}
+					if c.Score == 0.0 {
+						continue
+					}
 					fmt.Fprintf(w, "  #%d: %.1fs at %s\n",
 						i+1, c.Region.Duration.Seconds(), formatTimestamp(c.Region.Start))
 					writeSilenceCandidateMetrics(w, c)
@@ -117,6 +127,9 @@ func DisplayAnalysisResults(w io.Writer, inputPath string, metadata *audio.Metad
 		} else {
 			// No elected candidate - print all in discovery order
 			for i, c := range measurements.SilenceCandidates {
+				if c.Score == 0.0 {
+					continue
+				}
 				fmt.Fprintf(w, "  #%d: %.1fs at %s\n",
 					i+1, c.Region.Duration.Seconds(), formatTimestamp(c.Region.Start))
 				writeSilenceCandidateMetrics(w, c)
diff --git a/internal/logging/report.go b/internal/logging/report.go
@@ -1652,12 +1652,11 @@ func writeDiagnosticSilence(f *os.File, measurements *processor.AudioMeasurement
 				fmt.Fprintf(f, "      Short-term:    %.1f LUFS\n", c.ShortTermLUFS)
 				fmt.Fprintf(f, "      True Peak:     %.1f dBTP\n", c.TruePeak)
 			} else {
-				reason := ""
 				if c.Score == 0.0 {
-					reason = " — rejected: too loud"
+					continue
 				}
-				fmt.Fprintf(f, "  Candidate %d:       %.1fs at %.1fs (score: %.3f, RMS %.1f dBFS)%s\n",
-					i+1, c.Region.Duration.Seconds(), c.Region.Start.Seconds(), c.Score, c.RMSLevel, reason)
+				fmt.Fprintf(f, "  Candidate %d:       %.1fs at %.1fs (score: %.3f, RMS %.1f dBFS)\n",
+					i+1, c.Region.Duration.Seconds(), c.Region.Start.Seconds(), c.Score, c.RMSLevel)
 			}
 		}
 	} else if measurements.NoiseProfile != nil {

Original file line number	Diff line number	Diff line change
`@@ -1652,12 +1652,11 @@ func writeDiagnosticSilence(f os.File, measurements processor.AudioMeasurement`
`1652`	`1652`	`fmt.Fprintf(f, " Short-term: %.1f LUFS\n", c.ShortTermLUFS)`
`1653`	`1653`	`fmt.Fprintf(f, " True Peak: %.1f dBTP\n", c.TruePeak)`
`1654`	`1654`	`} else {`
`1655`		`- reason := ""`
`1656`	`1655`	`if c.Score == 0.0 {`
`1657`		`- reason = " — rejected: too loud"`
	`1656`	`+ continue`
`1658`	`1657`	`}`
`1659`		`- fmt.Fprintf(f, " Candidate %d: %.1fs at %.1fs (score: %.3f, RMS %.1f dBFS)%s\n",`
`1660`		`- i+1, c.Region.Duration.Seconds(), c.Region.Start.Seconds(), c.Score, c.RMSLevel, reason)`
	`1658`	`+ fmt.Fprintf(f, " Candidate %d: %.1fs at %.1fs (score: %.3f, RMS %.1f dBFS)\n",`
	`1659`	`+ i+1, c.Region.Duration.Seconds(), c.Region.Start.Seconds(), c.Score, c.RMSLevel)`
`1661`	`1660`	`}`
`1662`	`1661`	`}`
`1663`	`1662`	`} else if measurements.NoiseProfile != nil {`