fix(processor): address nil pointer risks and formatting edge cases

flexiondotorg · flexiondotorg · commit 0c539db29409 · 2026-01-16T18:17:36.000Z
- Add nil guards for inputMeasurements in normalise.go before accessing NoiseProfile and SpeechProfile - Add +Inf check in formatMetricLUFS for consistency with formatMetricDB - Add nil guards for result.Measurements in processor_test.go (4 locations) - Fix copy-paste comment error in analyzer.go Addresses review feedback from PR #5
diff --git a/internal/logging/table.go b/internal/logging/table.go
@@ -183,7 +183,7 @@ const LUFSMeasurementFloor = -70.0
 // formatMetricLUFS formats a LUFS value with special handling for values below measurement floor.
 // Shows "< -70" for values below the ebur128 measurement threshold.
 func formatMetricLUFS(value float64, decimals int) string {
-	if math.IsNaN(value) {
+	if math.IsNaN(value) || math.IsInf(value, 1) {
 		return MissingValue
 	}
 	// ebur128 can report values well below -70 for near-silent signals
diff --git a/internal/processor/analyzer.go b/internal/processor/analyzer.go
@@ -3727,7 +3727,7 @@ func MeasureOutputSpeechRegion(outputPath string, region SpeechRegion) (*SpeechC
 	}
 
 	if !rmsLevelFound {
-		metrics.RMSLevel = -60.0 // Conservative fallback for silence
+		metrics.RMSLevel = -60.0 // Conservative fallback
 	}
 
 	return metrics, nil
diff --git a/internal/processor/normalise.go b/internal/processor/normalise.go
@@ -662,7 +662,7 @@ func applyLoudnormAndMeasure(
 
 	// Measure silence region in final output (same region as Pass 1 noise profile)
 	// NOTE: inputPath now contains the normalised output after os.Rename above
-	if inputMeasurements.NoiseProfile != nil {
+	if inputMeasurements != nil && inputMeasurements.NoiseProfile != nil {
 		silenceRegion := SilenceRegion{
 			Start:    inputMeasurements.NoiseProfile.Start,
 			End:      inputMeasurements.NoiseProfile.Start + inputMeasurements.NoiseProfile.Duration,
@@ -676,7 +676,7 @@ func applyLoudnormAndMeasure(
 
 	// Measure speech region in final output (same region as Pass 1 speech profile)
 	// NOTE: inputPath now contains the normalised output after os.Rename above
-	if inputMeasurements.SpeechProfile != nil {
+	if inputMeasurements != nil && inputMeasurements.SpeechProfile != nil {
 		speechRegion := SpeechRegion{
 			Start:    inputMeasurements.SpeechProfile.Region.Start,
 			End:      inputMeasurements.SpeechProfile.Region.End,
diff --git a/internal/processor/processor_test.go b/internal/processor/processor_test.go
@@ -70,7 +70,7 @@ func TestProcessAudio(t *testing.T) {
 		t.Error("ProcessAudio returned nil FilteredMeasurements")
 	} else {
 		// Verify silence sample measurements are captured in Pass 2 output (if NoiseProfile exists)
-		if result.Measurements.NoiseProfile != nil {
+		if result.Measurements != nil && result.Measurements.NoiseProfile != nil {
 			t.Logf("NoiseProfile exists: Start=%v, Duration=%v", result.Measurements.NoiseProfile.Start, result.Measurements.NoiseProfile.Duration)
 			if result.FilteredMeasurements.SilenceSample == nil {
 				t.Error("FilteredMeasurements.SilenceSample is nil despite NoiseProfile existing")
@@ -83,7 +83,7 @@ func TestProcessAudio(t *testing.T) {
 		}
 
 		// Verify speech sample measurements are captured in Pass 2 output (if SpeechProfile exists)
-		if result.Measurements.SpeechProfile != nil {
+		if result.Measurements != nil && result.Measurements.SpeechProfile != nil {
 			t.Logf("SpeechProfile exists: Region=%v", result.Measurements.SpeechProfile.Region)
 			if result.FilteredMeasurements.SpeechSample == nil {
 				t.Error("FilteredMeasurements.SpeechSample is nil despite SpeechProfile existing")
@@ -99,7 +99,7 @@ func TestProcessAudio(t *testing.T) {
 	// Verify final measurements are populated (Pass 4 output analysis after normalisation)
 	if result.NormResult != nil && result.NormResult.FinalMeasurements != nil {
 		// Verify silence sample measurements are captured in Pass 4 output (if NoiseProfile exists)
-		if result.Measurements.NoiseProfile != nil {
+		if result.Measurements != nil && result.Measurements.NoiseProfile != nil {
 			if result.NormResult.FinalMeasurements.SilenceSample == nil {
 				t.Error("FinalMeasurements.SilenceSample is nil despite NoiseProfile existing")
 			} else {
@@ -109,7 +109,7 @@ func TestProcessAudio(t *testing.T) {
 		}
 
 		// Verify speech sample measurements are captured in Pass 4 output (if SpeechProfile exists)
-		if result.Measurements.SpeechProfile != nil {
+		if result.Measurements != nil && result.Measurements.SpeechProfile != nil {
 			if result.NormResult.FinalMeasurements.SpeechSample == nil {
 				t.Error("FinalMeasurements.SpeechSample is nil despite SpeechProfile existing")
 			} else {

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ const LUFSMeasurementFloor = -70.0`
`183`	`183`	`// formatMetricLUFS formats a LUFS value with special handling for values below measurement floor.`
`184`	`184`	`// Shows "< -70" for values below the ebur128 measurement threshold.`
`185`	`185`	`func formatMetricLUFS(value float64, decimals int) string {`
`186`		`- if math.IsNaN(value) {`
	`186`	`+ if math.IsNaN(value) \|\| math.IsInf(value, 1) {`
`187`	`187`	`return MissingValue`
`188`	`188`	`}`
`189`	`189`	`// ebur128 can report values well below -70 for near-silent signals`
Original file line number	Diff line number	Diff line change
`@@ -3727,7 +3727,7 @@ func MeasureOutputSpeechRegion(outputPath string, region SpeechRegion) (*SpeechC`
`3727`	`3727`	`}`
`3728`	`3728`
`3729`	`3729`	`if !rmsLevelFound {`
`3730`		`- metrics.RMSLevel = -60.0 // Conservative fallback for silence`
	`3730`	`+ metrics.RMSLevel = -60.0 // Conservative fallback`
`3731`	`3731`	`}`
`3732`	`3732`
`3733`	`3733`	`return metrics, nil`