refactor: code smells remediation across audio and ui packages#29
Merged
flexiondotorg merged 1 commit intomainfrom Mar 31, 2026
Merged
refactor: code smells remediation across audio and ui packages#29flexiondotorg merged 1 commit intomainfrom
flexiondotorg merged 1 commit intomainfrom
Conversation
- Remove FrameAnalysis.BarMagnitudes and Profile.Frames; fields were populated but never read, wasting ~27MB heap for 30-min audio; progress callback bar display preserved via a reusable buffer - Extract decodeS16/decodeS32/decodeF32/sampleDecoder/unsafeByteSlice helpers from extractSamples, reducing it from ~189 to ~58 lines; add unit tests with edge cases for each decoder - Move fire colour palette from internal/cli to internal/theme as the single source of truth; remove re-aliased vars in ui/progress.go, eliminating ui's dependency on internal/cli - Note in AGENTS.md that convertRGBAToYUV/convertRGBAToNV12 duplication is intentional for hot-path performance Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
No issues found across 8 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Refactors core audio decoding logic using unsafe pointers and modifies the primary data structure for audio analysis. These changes to high-performance paths require human validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist