Add Support for Typelib Packaging#33
Conversation
This allows for apps that use other language bindings to be packaged using linuxdeploy. For example, PyGObject uses the typelibs to introspect bindings for Python.
Use default locations for Ubuntu in case libgtk-3-dev and librsvg2-dev are not installed. A Python app wouldn't normally require these dependencies, so use default values as a fallback during packaging for linuxdeploy.
|
Hello, Your PR is breaking CI pipelines: please fix. |
|
I don't think these paths are a big problem They are used during build time only. Also, they are just fallback values, and additional libdirs could always be added, I guess. Typically, the value should be available from |
The default typelib directory was incorrectly pointing to a location for rpm based distros which was causing CI to fail with a library not found error.
|
I 100% agree that the default paths are completely Debian/Ubuntu specific, but adding a fallback to a typical location I think only helps. I pushed a commit that fixes the default path for the typelibs which should fix the CI failure. 👍 If we wanted to, we could remove libgtk-3-dev as a dependency for CI, because the default path should make it not needed. |
|
@X0rg Could you please restart the CI for me? |
|
Done. |
|
Ok, if you are fine with these fallback paths, then it looks good to me. |
|
Dockerfiles updated! |
|
@X0rg or @TheAssassin could you please reapprove the checks? Thanks! |
|
Please approve the workflows again, thanks! 👍 |
|
One more time please, they are now all passing locally with Docker. |
|
I didn't realize this was going to impact the GTK4 builds as well, PR updated to include more dependencies for them. 👍 Could you please reapprove the workflow? |
|
We get notifications for every commit. No need to double the amount of mails. You don't need to ask every time. |
|
Also, you could test changes in your own repository, then you don't have to wait here. |
|
@TheAssassin Thanks, sorry for the doubling up. I have never run GitHub Actions on a fork of a repo, and it looks like I can enable them by going to the actions tab, thanks for the pointer! It looks like all the checks finally passed, apologies again for having to reapprove the checks again and again, it was frustrating for me as well. |
|
@X0rg maybe you could have another look? Please don't hesitate to merge if this works for you. |
|
LGTM. |
|
@X0rg and @TheAssassin thanks for your support helping to get this merged! 👍 |
This PR adds support for installing girepository typelibs and adds additional default pkg-config locations.
Currently, the plugin is not packaging any typelibs. These allow for apps that use other language bindings to be packaged using linuxdeploy. For example, PyGObject uses the typelibs to introspect bindings for Python.
Additionally, this PR adds additional default locations for Ubuntu in case libgtk-3-dev and librsvg2-dev are not installed. A Python app wouldn't normally require these dependencies, so use default values as a fallback during packaging for linuxdeploy. Although I don't use Ubuntu myself, this is the typical setup, especially with CI runners and Docker.
Finally, it fixes a small issue with the symbolic link step at the end, which fails if the symbolic links already exist.