BUGFIX: targets/split_8mb4mb.mk Makefile: Make sure top/bottom/rom hash+size are always outputted in console+hashes.txt+sizes.txt #1834
Conversation
1f25857 to
92b99dc
Compare
|
@JonathonHall-Purism : better approach with your Make fu? |
92b99dc to
9e3f0fe
Compare
…sh+size are always outputted in console+hashes.txt+sizes.txt Signed-off-by: Thierry Laurion <insurgo@riseup.net>
9e3f0fe to
a0c3d8e
Compare
|
@JonathonHall-Purism punched an exclusion in global Makefile in case not spllitted 12mb rom image. Best I could imagine! Works locally (tested nv41/t430 to address #1829 (comment) which revived need to fix #1534 for pending feature freeze/bugfixes) |
| $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE) | ||
| $(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none) | ||
| @sha256sum $@ | tee -a "$(HASHES)" | ||
| bottom: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom |
There was a problem hiding this comment.
If you want, you could make a variable that holds $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION) because that's so long and repeated so many times, e.g. BUILD_ROM_PREFIX=$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION). But not required at all, I'd be happy merging as-is.
JonathonHall-Purism
left a comment
There was a problem hiding this comment.
Looks good to me! I did make one suggestion but not a requirement by any means, just a thought. I'd be happy to merge it as-is.
fix #1534