Closed
Conversation
added 2 commits
September 25, 2014 18:18
Created with a list of memcache servers client has non-zero chance to fail any operation involving server selection due to _get_server() sometimes fails to find single alive server among dead ones. Changed server search routine to perform each new server search excluding dead server.
Created with a list of memcache servers client has non-zero chance to fail any operation involving server selection due to _get_server() sometimes fails to find single alive server among dead ones. Changed server search routine to perform each new server search excluding dead server. Updated to run under Python 3 Bug filed in Mirantis OpenStack: https://bugs.launchpad.net/mos/+bug/1370324
Owner
|
I'm reluctant to change this algorithm, particularly in this way. As a maintenance change, we can't just go changing the server selection algorithm, "buggy" or not... The only way I am likely to be able to take a change to the server selection algorithm is to make it "plugable", so that an alternate algorithm can be selected at run-time, with the default staying as it is. Additionally, the correct fix for server selection algorithm is likely to be Consistent Hashing: http://en.wikipedia.org/wiki/Consistent_hashing An implementation of Consistent Hashing is at: https://github.com/linsomniac/python-memcached2/blob/master/memcached2.py -- search for ConsistentHashing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created with a list of memcache servers client has non-zero chance
to fail any operation involving server selection due to _get_server()
sometimes fails to find single alive server among dead ones.
Changed server search routine to perform each new server search
excluding dead server.
More detailed description here:
https://bugs.launchpad.net/mos/+bug/1370324