Demo changes to crossplane/runtime for deterministic external name#329
Closed
Demo changes to crossplane/runtime for deterministic external name#329
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 38.62% 38.62%
=======================================
Files 61 61
Lines 5629 5618 -11
=======================================
- Hits 2174 2170 -4
+ Misses 3325 3319 -6
+ Partials 130 129 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR is a demo of how [insert PR] is used by a downstream crossplane provider.
Changes in this PR:
nolancon/crossplane-runtimecreate-pendingannotation after it has been applied. See detailed workaround description here.external-name-is-deterministicannotation to the edge-case bucket. This test case was specifically written to exercise the above workaround - it is not always guaranteed to pass as the workaround is "best-effort" as described. See full description of this test case here.By removing the above workaround, and instead, making use of the new annotation in the patched version of crossplane-runtime - the desired effect is achieved and it is no longer on a "best-effort" basis. As demonstrated by passing Chainsaw tests under the new circumstances.
I have:
make reviewableto ensure this PR is ready for review.make ceph-chainsawto validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. Seedocs/TESTING.mdfor information on how to run tests against a Ceph cluster.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested