fix: reattempt password validity reset on any expiration error#2927
Merged
CasLubbers merged 9 commits intomainfrom Feb 11, 2026
Merged
fix: reattempt password validity reset on any expiration error#2927CasLubbers merged 9 commits intomainfrom
CasLubbers merged 9 commits intomainfrom
Conversation
j-zimnowoda
reviewed
Feb 9, 2026
j-zimnowoda
reviewed
Feb 9, 2026
Contributor
j-zimnowoda
left a comment
There was a problem hiding this comment.
Tested on running cluster bu logging to gitea pod and performing
gitea-6cbbbb5f46-vnqhc:/var/lib/gitea$ gitea admin user must-change-password otomi-admin
Updated 1 users setting MustChangePassword to true
Then restarted the apl-operator and saw the following logs:
Collected logs
2026-02-09T14:13:46.720Z otomi:cmd:traces:collectTraces:info Collecting traces from cluster resources...
remote: Update your password
fatal: Authentication failed for 'http://gitea-http.gitea.svc.cluster.local:3000/otomi/values.git/'
2026-02-09T14:13:46.885Z otomi:common:gitea:resetGiteaPasswordValidity:info Resetting status of Gitea admin credentials
2026-02-09T14:13:47.294Z otomi:cmd:traces:collectTraces:info Trace report stored in ConfigMap apl-operator/apl-traces-report (11 issues)
2026-02-09T14:13:47.298Z otomi:common:gitea:resetGiteaPasswordValidity:info Updated 1 users setting MustChangePassword to false
2026-02-09T14:13:47.383Z otomi:operator:git-repository:info Cloning repository to /home/app/stack/env
j-zimnowoda
approved these changes
Feb 9, 2026
CasLubbers
approved these changes
Feb 11, 2026
Contributor
|
Need to update this in the BYO Git branch |
Ani1357
pushed a commit
that referenced
this pull request
Feb 17, 2026
Co-authored-by: svcAPLBot <174728082+svcAPLBot@users.noreply.github.com> (cherry picked from commit 6087291)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR aims to fix a sporadically reoccurring issue where the Gitea password is marked as expired while Gitea is either initialized or upgraded. This was implemented before, but only once during an upgrade.
🔍 Reviewer Notes
The function
resetGiteaPasswordValidityhas not been modified but moved because it is no longer only part of an upgrade. It was using utility functions of thek8smodule; thereforewaitTillGitRepoAvailablewas moved out as well for avoiding mutual dependencies. This function was modified to invoke the password validity reset.🧹 Checklist