feat: custom kubernetes manifest in the values repo#2893
Merged
Conversation
2 tasks
CasLubbers
reviewed
Jan 30, 2026
CasLubbers
requested changes
Jan 30, 2026
Contributor
CasLubbers
left a comment
There was a problem hiding this comment.
Tested on cluster.
Created two directories
${ENV_DIR}/
└── env/
└── manifests/
├── global/
│ └── test-configmap.yaml
└── ns/
└── team-demo/
└── configmap.yaml
Both got created. Afterwards deleted them the gitops-global app was still there and the team-demo one got deleted with its resources. ✅
Only one comment about making the applyGitOpsApps more readable. The rest looks good to me
Contributor
|
Comparison of Helm chart templating output: @@ spec.ingress @@
! + one list entry added:
+ - from:
+ - namespaceSelector:
+ matchLabels:
+ name: argocd
+ podSelector:
+ matchLabels:
+ app.kubernetes.io/name: argocd-repo-server
@@ (root level) @@
! + one document added:
+ ---
+ # Source: raw/templates/resources.yaml
+ apiVersion: v1
+ data:
+ url: aHR0cDovL2dpdGVhLWh0dHAuZ2l0ZWEuc3ZjLmNsdXN0ZXIubG9jYWw6MzAwMC9vdG9taS92YWx1ZXMuZ2l0
+ password: Z2l0ZWFBZG1pblBhc3N3b3Jk
+ type: Z2l0
+ username: b3RvbWktYWRtaW4=
+ kind: Secret
+ metadata:
+ name: argocd-repo-creds-gitea-internal
+ namespace: argocd
+ labels:
+ app: raw
+ app.kubernetes.io/instance: argocd-artifacts
+ app.kubernetes.io/managed-by: Helm
+ app.kubernetes.io/name: raw
+ app.kubernetes.io/part-of: otomi
+ app.kubernetes.io/version: 0.2.3
+ argocd.argoproj.io/secret-type: repo-creds
+ helm.sh/chart: raw-0.2.3
@@ metadata @@
! + one map entry added:
+ labels:
+ otomi.io/app: team-gitops
@@ metadata @@
! + one map entry added:
+ labels:
+ otomi.io/app: team-gitops
@@ metadata @@
! + one map entry added:
+ labels:
+ otomi.io/app: team-gitops |
CasLubbers
approved these changes
Jan 30, 2026
ElderMatt
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR enhances the functionality by responding to creation of Kubernetes manifest files in specific directories of the values repository. Files created in env/manifests/ns// result in creation of an ArgoCD application that creates and deploys everything into the namespace with the directory name. Manifest files stored in env/manifest/global/ are intended for cluster-wide objects and therefore do not imply a target namespace, and do not create any.
Removing any of the namespace directories removes the ArgoCD application as well. Removing all manifests from global does not remove the ArgoCD application, due to risks arising from deleting cluster-wide objects.
In order to avoid unintended changes to unrelated ArgoCD applications, labels are added and used for selection. The platform app updates have been extended accordingly.
🔍 Reviewer Notes
Verifying that the namespace matches the directory name has been out of scope of the defined functionality, therefore the manifest can override the target deployment namespace. Additional functionality is planned to be implemented in the API.
🧹 Checklist